You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/04 17:17:52 UTC
[GitHub] [apisix-website] iamayushdas opened a new pull request #361: feat: added doc name to doc dropdown selection
iamayushdas opened a new pull request #361:
URL: https://github.com/apache/apisix-website/pull/361
Fixes: #360
Changes:
added the navigated doc page name to docs dropdown
Screenshots of the change:
live url: https://apisix-website-navigation.netlify.app/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-857932338
Hi @iamayushdas could you update `apisix-website-navigation.netlify.app`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640
:heavy_check_mark: Deploy Preview for *apisix* ready!
:hammer: Explore the source changes: a49ddc9ac7124119b4b8b8f82e25819b584954fc
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60c0fb0bd798e30008e9913f](https://app.netlify.com/sites/apisix/deploys/60c0fb0bd798e30008e9913f?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-361--apisix.netlify.app](https://deploy-preview-361--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on a change in pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#discussion_r647470905
##########
File path: website/src/theme/DocPage/index.js
##########
@@ -26,6 +26,26 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
docsSidebars,
version,
} = versionMetadata;
+
+ useEffect(() => {
+ if(docsSidebars[sidebarName][0].label === "General"){
+ document.querySelectorAll(".navbar__link--active")[0].text = "General";
+ } else if (document.getElementById("getting-started")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX";
+ } else if (document.getElementById("dashboard")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX Dashboard";
+ } else if (document.getElementById("what-is-apisix-ingress-controller")) {
Review comment:
Yes we can,
Do you also want me to separate the selectors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-856556552
That's a good feature!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #361:
URL: https://github.com/apache/apisix-website/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854886239
cc @Yiyiyimu @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640
:heavy_check_mark: Deploy Preview for *apisix* ready!
:hammer: Explore the source changes: 333cbab640782c4efa21073e0540091766868a3f
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9](https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-361--apisix.netlify.app](https://deploy-preview-361--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640
:construction_worker: Deploy Preview for *apisix* processing.
:hammer: Explore the source changes: 333cbab640782c4efa21073e0540091766868a3f
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9](https://app.netlify.com/sites/apisix/deploys/60ba60370232d7000900ada9?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-854885640
:construction_worker: Deploy Preview for *apisix* processing.
:hammer: Explore the source changes: a49ddc9ac7124119b4b8b8f82e25819b584954fc
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60c0fb0bd798e30008e9913f](https://app.netlify.com/sites/apisix/deploys/60c0fb0bd798e30008e9913f?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#discussion_r647214880
##########
File path: website/src/theme/DocPage/index.js
##########
@@ -26,6 +26,26 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
docsSidebars,
version,
} = versionMetadata;
+
+ useEffect(() => {
+ if(docsSidebars[sidebarName][0].label === "General"){
+ document.querySelectorAll(".navbar__link--active")[0].text = "General";
+ } else if (document.getElementById("getting-started")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX";
+ } else if (document.getElementById("dashboard")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX Dashboard";
+ } else if (document.getElementById("what-is-apisix-ingress-controller")) {
Review comment:
Maybe we could maintain a mapper here, like:
```
{
"dashboard": "Apache APISIX Dashboard"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-855019891
@iamayushdas Cool! Thanks a lot!!! 🚀
Found one problem is that `APISIX` and `dashboard` page still got their own links on the sidebar, others are good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#discussion_r647917033
##########
File path: website/src/theme/DocPage/index.js
##########
@@ -26,6 +26,26 @@ function DocPageContent({ currentDocRoute, versionMetadata, children }) {
docsSidebars,
version,
} = versionMetadata;
+
+ useEffect(() => {
+ if(docsSidebars[sidebarName][0].label === "General"){
+ document.querySelectorAll(".navbar__link--active")[0].text = "General";
+ } else if (document.getElementById("getting-started")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX";
+ } else if (document.getElementById("dashboard")) {
+ document.querySelectorAll(".navbar__link--active")[0].text = "Apache APISIX Dashboard";
+ } else if (document.getElementById("what-is-apisix-ingress-controller")) {
Review comment:
yes, make it more clearly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on pull request #361: feat: added doc name to doc dropdown selection
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #361:
URL: https://github.com/apache/apisix-website/pull/361#issuecomment-855155098
> @iamayushdas Cool! Thanks a lot!!! 🚀
>
>
>
> Found one problem is that `APISIX` and `dashboard` page still got their own links on the sidebar, others are good to me
Your wlcm,
Yes that will be removed by there origin repo. Will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org