You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Wade Simmons (JIRA)" <ji...@apache.org> on 2015/12/18 01:21:47 UTC

[jira] [Created] (THRIFT-3494) Node.js should use Buffer.isBuffer

Wade Simmons created THRIFT-3494:
------------------------------------

             Summary: Node.js should use Buffer.isBuffer
                 Key: THRIFT-3494
                 URL: https://issues.apache.org/jira/browse/THRIFT-3494
             Project: Thrift
          Issue Type: Bug
          Components: Node.js - Library
    Affects Versions: 0.9.3
            Reporter: Wade Simmons


Newer versions of Node.js (such as 4.2.x) use multiple implementations for Buffer objects and you cannot just use {{instanceof Buffer}} to detect them. Node instead has provided a {{Buffer.isBuffer}} method since at least version 0.8 which should be used to detect buffers.

The current {{instanceof Buffer}} method can fail like this with Node 4.2.3:

{{{
Error: writeString called without a string/Buffer argument: [object ArrayBuffer]
}}}

Opening Github pull request with the patch shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)