You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/16 05:44:25 UTC

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4060: feat: update skywalking componentId

Firstsawyou commented on a change in pull request #4060:
URL: https://github.com/apache/apisix/pull/4060#discussion_r614574061



##########
File path: apisix/plugins/skywalking.lua
##########
@@ -17,6 +17,7 @@
 local sw_tracer = require("skywalking.tracer")
 local core = require("apisix.core")
 local process = require("ngx.process")
+local Span = require('skywalking.span')

Review comment:
       I think it would be better to keep the style uniform.
   
   ```suggestion
   local Span = require("skywalking.span")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org