You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/20 13:25:21 UTC
[GitHub] [beam] steveniemitz commented on a change in pull request #11154:
[BEAM-1819] Key should be available in @OnTimer methods
steveniemitz commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r395633155
##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java
##########
@@ -361,6 +361,7 @@ private void processUserTimer(TimerData timer) throws Exception {
fnRunner.onTimer(
timer.getTimerId(),
timer.getTimerFamilyId(),
+ this.stepContext.stateInternals().getKey(),
Review comment:
you'll need the change to StreamingDataflowWorker as well, without it, the key will be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services