You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fabrizio Lungo (JIRA)" <ji...@apache.org> on 2016/04/02 15:17:25 UTC

[jira] [Comment Edited] (MNG-5951) add an option to avoid path addition to inherited URLs

    [ https://issues.apache.org/jira/browse/MNG-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222882#comment-15222882 ] 

Fabrizio Lungo edited comment on MNG-5951 at 4/2/16 1:16 PM:
-------------------------------------------------------------

I like this, could also lead to the ability to have an attribute to completely disable inheritance of a value where you want it specified in the parent for documentation but not carried through to the child - the first thing that comes to mind is {{description}}. This may require that `inherit` is a boolean and the inherited value override is set with an {{inheritValue}} attribute?

Any implementation should also be used by the Super POM so that all inheritance logic is moved from Java code that you need to really hunt through to find to being included in the super POM. For example the super POM could contain (to maintain backwards compatibility):

{code}
<scm>
    <connection inherit="${parent.scm.connection}/${project.artifactId}" />
    <developerConnection inherit="${parent.scm.developerConnection}/${project.artifactId}" />
    <url inherit="${parent.scm.url}/${project.artifactId}" />
</scm>
{code}

Has there been any progress on this?


was (Author: flungo):
I like this, could also lead to the ability to have an attribute to completely disable inheritance of a value where you want it specified in the parent for documentation but not carried through to the child - the first thing that comes to mind is `description`. This may require that `inherit` is a boolean and the inherited value override is set with an `inheritValue` attribute?

Any implementation should also be used by the Super POM so that all inheritance logic is moved from Java code that you need to really hunt through to find to being included in the super POM. For example the super POM could contain (to maintain backwards compatibility):

```
<scm>
    <connection inherit="${parent.scm.connection}/${project.artifactId}" />
    <developerConnection inherit="${parent.scm.developerConnection}/${project.artifactId}" />
    <url inherit="${parent.scm.url}/${project.artifactId}" />
</scm>
```

Has there been any progress on this?

> add an option to avoid path addition to inherited URLs
> ------------------------------------------------------
>
>                 Key: MNG-5951
>                 URL: https://issues.apache.org/jira/browse/MNG-5951
>             Project: Maven
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>    Affects Versions: 3.0.5, 3.1.1, 3.2.5, 3.3.9
>            Reporter: Jörg Sesterhenn
>             Fix For: waiting-for-feedback, 3.4.0
>
>         Attachments: MNG-5951.zip
>
>
> What I am trying to achieve is 
> the definition of a project.url in a parent pom 
> in a way that all children inherit a url ending with 
> {code}
> ${project.groupId}/${project.artifactId}/${project.version}/ 
> {code}
> in order to be able to publish sites of all artifacts in all versions in parallel
> without having to redefine the url in every child pom.
> This is currently not working as expected in maven due to the default child urls calculation which leads to urls that add up parent urls like 
> http://my.domain.de/sites/de.enterprise.calculatorsGroupId/calculator-artifactID/1.0.0-SNAPSHOT/internetAppParentPOM/calculatorParentPom/calculator-artifactID/
> The part *"internetAppParentPOM/calculatorParentPom/"* is added by automatic child url calculation (those are the artifactIds of all parent poms beneath our enterprise parent pom where the url is defined) and *is expexted to not be there at all*. The repeated artifactID at the end of the url is superfluous as well but tollerable.
> I expect maven-core to be changed so that I can turn on/off the automatic calculation of child URLs as an option which is by default on (current behaviour so nothing will change unless configured explicitly).
> See the discussion in MSITE-672. 
> As this can not be done in the maven-site-plugin there needs to be a change in Maven itself (core), in Maven Model Builder, ie the way effective model is calculated, and more precisely in the inheritance step: http://maven.apache.org/ref/current/maven-model-builder/.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)