[GitHub] [hive] marton-bod commented on a change in pull request #2458: HIVE-25314: Implement SHOW CREATE TABLE command for Iceberg tables

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r666230993



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
##########
@@ -257,6 +258,16 @@ default boolean supportsPartitionTransform() {
     return false;
   }
 
+  /**
+   * Return the partition transform specification table property key together with the specification value in json

Review comment:
       Maybe mention in the docs that this should be overridden only if the `supportsPartitionTransform()` method is true?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org