You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/11/09 01:23:46 UTC

Review Request 73695: RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73695/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3507
    https://issues.apache.org/jira/browse/RANGER-3507


Repository: ranger


Description
-------

RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java 880e4851f 
  agents-common/src/test/resources/policyengine/test_policyengine_hive.json 70d7e648b 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java ddc0982a6 


Diff: https://reviews.apache.org/r/73695/diff/1/


Testing
-------

- Verified in local vm HIVE commmand with URL in them.
- Verified in Unit test.


Thanks,

Ramesh Mani


Re: Review Request 73695: RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73695/#review223757
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Nov. 15, 2021, 7:46 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73695/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2021, 7:46 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3507
>     https://issues.apache.org/jira/browse/RANGER-3507
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java 880e4851f 
>   agents-common/src/test/resources/policyengine/test_policyengine_hive.json 70d7e648b 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java ddc0982a6 
> 
> 
> Diff: https://reviews.apache.org/r/73695/diff/2/
> 
> 
> Testing
> -------
> 
> - Verified in local vm HIVE commmand with URL in them.
> - Verified in Unit test.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 73695: RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73695/
-----------------------------------------------------------

(Updated Nov. 15, 2021, 7:46 p.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Updated patch after review


Bugs: RANGER-3507
    https://issues.apache.org/jira/browse/RANGER-3507


Repository: ranger


Description
-------

RANGER-3507:Handle trailing slash in the ranger Hive URL policy authorization


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java 880e4851f 
  agents-common/src/test/resources/policyengine/test_policyengine_hive.json 70d7e648b 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java a3d575c86 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java ddc0982a6 


Diff: https://reviews.apache.org/r/73695/diff/2/

Changes: https://reviews.apache.org/r/73695/diff/1-2/


Testing
-------

- Verified in local vm HIVE commmand with URL in them.
- Verified in Unit test.


Thanks,

Ramesh Mani