[GitHub] [dolphinscheduler] caishunfeng commented on pull request #10998: [Feature-10983] [refactor] ResourcesController

[GitBox <gi...@apache.org>]

caishunfeng commented on PR #10998:
URL: https://github.com/apache/dolphinscheduler/pull/10998#issuecomment-1207646526

   > > > It‘s better to create a new branch e.g. api-refactor, and don't merge this kind of pr to dev, otherwise, we may need to solve many conflicts before 4.0 @SbloodyS @caishunfeng @liguotian
   > > 
   > > 
   > > I find this patch almost adds new files and only changes the existing file `ResourcesController`, so it can be cherry-picked without not to many conflicts, So I think we can be merge into dev branch, I think I think the one need to create a new branch to keep code it significant change not compatible with the current code/function(maybe part of DSIP or foundation), and we didn't want to release it int the next released
   > 
   > AFAIK, the PR related to this issue #10257 will be released at 4.0 :), and most of these might be incompatible.
   
   In my opinion, it should be merged in dev, which is always the latest branch. The question is to reduce the cherry-pick cost with less conflicts, what about spliting the pr into two parts, one is the service logic,another is the v2 controller and dto? When cherry-pick, we just cp the first one part without v2 controller logic. WDYT? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org