You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/02/05 06:57:46 UTC

Review Request: Refactored all Option::none and Result::none to use None.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/
-----------------------------------------------------------

Review request for mesos, Vinod Kone and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
  src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
  src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
  src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
  src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
  src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
  src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
  src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
  src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
  src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
  src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
  src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
  src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
  src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
  src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
  src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
  src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
  src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
  src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
  src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
  src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
  third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
  third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
  third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
  third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
  third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
  third_party/libprocess/include/stout/none.hpp PRE-CREATION 
  third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
  third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
  third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
  third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
  third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 

Diff: https://reviews.apache.org/r/9307/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Feb. 5, 2013, 11:23 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/stout/none.hpp, line 43
> > <https://reviews.apache.org/r/9307/diff/1/?file=255549#file255549line43>
> >
> >     What about the analog in error.hpp?

There is one in error.hpp too ...


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16149
-----------------------------------------------------------


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16149
-----------------------------------------------------------



third_party/libprocess/include/stout/none.hpp
<https://reviews.apache.org/r/9307/#comment34559>

    What about the analog in error.hpp?


- Vinod Kone


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16148
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Feb. 5, 2013, 11:56 p.m., Ben Mahler wrote:
> > src/flags/flags.hpp, line 47
> > <https://reviews.apache.org/r/9307/diff/1/?file=255528#file255528line47>
> >
> >     Does this not invoke the implicit constructor?
> >     values["debug"] = "true";
> >     or
> >     values["debug"] = string("true");

Nope, the type information can't be forwarded appropriately. Issues like this precipitate the Some type being useful (since it is usually not).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16150
-----------------------------------------------------------


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16150
-----------------------------------------------------------

Ship it!



src/flags/flags.hpp
<https://reviews.apache.org/r/9307/#comment34560>

    Does this not invoke the implicit constructor?
    values["debug"] = "true";
    or
    values["debug"] = string("true");


- Ben Mahler


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16369
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Feb. 8, 2013, 5:55 a.m., Chris Mattmann wrote:
> > src/flags/flags.hpp, line 45
> > <https://reviews.apache.org/r/9307/diff/1/?file=255528#file255528line45>
> >
> >     Any reason to leave commented out code, checked in? I realize I may be off here, but thought I'd jump in and comment since I'm now on the list :)

This comment is just an example of how someone might use this class. Otherwise we generally DO NOT keep commented code checked in, so you are in fact right on! ;)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16336
-----------------------------------------------------------


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16336
-----------------------------------------------------------



src/flags/flags.hpp
<https://reviews.apache.org/r/9307/#comment34804>

    Any reason to leave commented out code, checked in? I realize I may be off here, but thought I'd jump in and comment since I'm now on the list :)


- Chris Mattmann


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Refactored all Option::none and Result::none to use None.

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9307/#review16338
-----------------------------------------------------------



src/flags/flags.hpp
<https://reviews.apache.org/r/9307/#comment34806>

    sounds great Ben, thanks!


- Chris Mattmann


On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9307/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 5:57 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.hpp d8ef9cbc6f781bc30601a4075d53c3cc31cc53c3 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/configurator/configuration.hpp c49fee104b1774c0820ff5525aaa042a1e7ce46f 
>   src/detector/detector.cpp ca921151a1fc1a57d265b3439d07a8c45e920f21 
>   src/files/files.cpp 60b567eb62e84ccc99b0b1978733a0ea96560813 
>   src/flags/flags.hpp f3f0bfde16947a4047cf45fd9ed67b1252bdf818 
>   src/linux/cgroups.cpp 03b31e7309b9dd65f00d3b0da2abb81ddaaeea43 
>   src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 
>   src/log/coordinator.cpp d9f67bd8b07e6f8b3e022c21f1764d298e314594 
>   src/log/log.hpp 151eebd5d665993dfaac399553a9a315c093762b 
>   src/log/replica.cpp 392cb15991657d8e79637e1c4bc21ec813e3117d 
>   src/logging/check_some.hpp 5408e8b7a5040f3e812c566e8455847da4c5a778 
>   src/master/frameworks_manager.cpp 189a7e3b4811643baf285ad29f939453257c705f 
>   src/state/leveldb.cpp 6137b5d089dc9ea4b60fd56153b72e14691df3d8 
>   src/state/state.hpp 1bc878a85b71d48c4430489d7dc68a7c7ccc531d 
>   src/state/zookeeper.cpp 4c684797791bb2158d31573d2d47b0da70283bc6 
>   src/tests/flags_tests.cpp 244b3ffd71b8e63fcdc8018b5da99fa1b210367b 
>   src/tests/fs_tests.cpp 2bf893068cb926448cc46519da1b6ec0b9405442 
>   src/tests/protobuf_io_tests.cpp 5c9bf4664d413a34859608dd727deacf3ce4b402 
>   src/zookeeper/group.hpp c5985b2af4e1a5e01904c00dcb3ba982748e9aa5 
>   src/zookeeper/group.cpp e74538e3dfa6951178f3e4b49dfd94374a0aa28c 
>   third_party/libprocess/include/process/collect.hpp 79c4fb8317a70a386ac2b92fcee98166e360f352 
>   third_party/libprocess/include/process/http.hpp 40248dab3df59b322ad9c5a4858961ef471779fd 
>   third_party/libprocess/include/process/statistics.hpp 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/include/stout/cache.hpp 44c6d9f8e741403f6cd2014bda153d557d058396 
>   third_party/libprocess/include/stout/hashmap.hpp ec02b69f821be9206079a1cdd1682d976af408b4 
>   third_party/libprocess/include/stout/none.hpp PRE-CREATION 
>   third_party/libprocess/include/stout/numify.hpp 2a59c9269902541d82ba86a2d159984f5bbc6b73 
>   third_party/libprocess/include/stout/os.hpp 712fb209061384b8c045875ef8898a6efd778514 
>   third_party/libprocess/include/stout/protobuf.hpp 25d4634bbc51d14ea78c1a922353f0ce52e458df 
>   third_party/libprocess/src/process.cpp 72e437862ee0b35126c16d32bec79ef76a4e2b23 
>   third_party/libprocess/src/statistics.cpp 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9307/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>