[GitHub] [airflow] uranusjr commented on a diff in pull request #34321: Refactor usage of str()

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #34321:
URL: https://github.com/apache/airflow/pull/34321#discussion_r1324252428


##########
airflow/utils/process_utils.py:
##########
@@ -90,8 +90,7 @@ def signal_procs(sig):
             # use sudo -n(--non-interactive) to kill the process
             if err_killpg.errno == errno.EPERM:
                 subprocess.check_call(
-                    ["sudo", "-n", "kill", "-" + str(int(sig))]
-                    + [str(p.pid) for p in all_processes_in_the_group]
+                    ["sudo", "-n", "kill", f"-{int(sig)}"] + [str(p.pid) for p in all_processes_in_the_group]

Review Comment:
   ```suggestion
                       ["sudo", "-n", "kill", f"-{int(sig)}", *(str(p.pid) for p in all_processes_in_the_group)]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org