[jira] [Commented] (YARN-3542) Re-factor support for CPU as a resource using the new ResourceHandler mechanism

["Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095259#comment-15095259 ] 

Vinod Kumar Vavilapalli commented on YARN-3542:
-----------------------------------------------

Okay, clearly most of my comments were rooted on the following question
bq. This effectively means the old code is not used anymore, and that the new code is stable.

And it seems like we are stating that
bq. [..], there should be no issue hooking into the new handler using the old configuration mechanism.?

Given this and the fact that we are internally overriding to use the new handlers, is there a reason for keeping the old code at all? Also if we are using the new handler code internally anyways, we can proceed with the deprecation (or better deletion) of LCEResourcesHandler interface, DefaultLCEResourcesHandler etc?

bq. When user sets the old CgroupsLCEResourcesHandler, you are internally resetting it to DefaultLCEResourcesHandler(inside LinuxContainerExecutor) and using that as a control to stop using the older handler.
Instead of doing this implicitly, how about we completely remove LinuxContainerExecutor.resourcesHandler etc as they don't perform any real function anymore.

> Re-factor support for CPU as a resource using the new ResourceHandler mechanism
> -------------------------------------------------------------------------------
>
>                 Key: YARN-3542
>                 URL: https://issues.apache.org/jira/browse/YARN-3542
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Sidharta Seethana
>            Assignee: Varun Vasudev
>            Priority: Critical
>         Attachments: YARN-3542.001.patch, YARN-3542.002.patch, YARN-3542.003.patch, YARN-3542.004.patch, YARN-3542.005.patch, YARN-3542.006.patch, YARN-3542.007.patch
>
>
> In YARN-3443 , a new ResourceHandler mechanism was added which enabled easier addition of new resource types in the nodemanager (this was used for network as a resource - See YARN-2140 ). We should refactor the existing CPU implementation ( LinuxContainerExecutor/CgroupsLCEResourcesHandler ) using the new ResourceHandler mechanism. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)