[GitHub] [apisix-dashboard] foolwc commented on pull request #1982: fix: make service chash key Input inputable and selectable

[GitBox <gi...@apache.org>]

foolwc commented on pull request #1982:
URL: https://github.com/apache/apisix-dashboard/pull/1982#issuecomment-886412222


   > @foolwc thanks for your nice work~! The current modification is LGTM, it can support customize the hash key.
   > 
   > And If you can add some test cases, it will help us merge your PR more quickly.
   > 
   > Just refer to
   > 
   > https://github.com/apache/apisix-dashboard/blob/0b5196f0b444dac8acb5cf60635806f024de6a0a/web/cypress/integration/upstream/create_and_delete_upstream.spec.js#L94
   > 
   > , you can try to add case about when choose `hash_on` cookie, you can type `key` a customize one and submit successfully.
   > And refer to
   > 
   > https://github.com/apache/apisix-dashboard/blob/0b5196f0b444dac8acb5cf60635806f024de6a0a/web/cypress/integration/upstream/create_and_delete_upstream.spec.js#L134
   > 
   > , you can try to add case about view the above upstream info as expected.
   > Thanks again, and looking forward to your test cases. If you have any question, please leave message here, we'll help you
   
   Thanks for your detailed explanation of  writing e2e test.  Please help me review my code again.  Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org