You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@cloudera.com> on 2016/08/18 09:37:11 UTC
Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/
-----------------------------------------------------------
Review request for Flume and Mike Percy.
Repository: flume-git
Description
-------
Changes in FLUME-2318 broke some tests that have empty files
Diffs
-----
flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
Diff: https://reviews.apache.org/r/51200/diff/
Testing
-------
[INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
[INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
[INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
[INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
[INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
[INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
[INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
[INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
[INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
[INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
[INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
[INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
[INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
[INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
[INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
[INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
[INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
[INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
[INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
[INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
[INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
[INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
[INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
[INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
[INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
[INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
[INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
[INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
[INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
[INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
[INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
[INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
[INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
[INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
[INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
[INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:00 min
Thanks,
Bal�zs Don�t Bessenyei
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
> On Aug. 21, 2016, 7:15 p.m., Mike Percy wrote:
> > Please remove all non-essential changes, spurious whitespace modifications, etc. Then resubmit.
Thanks for the review. Done
- Bal�zs Don�t
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/#review146268
-----------------------------------------------------------
On Aug. 21, 2016, 9:58 p.m., Bal�zs Don�t Bessenyei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51200/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2016, 9:58 p.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Changes in FLUME-2318 broke some tests that have empty files
>
>
> Diffs
> -----
>
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
>
> Diff: https://reviews.apache.org/r/51200/diff/
>
>
> Testing
> -------
>
> [INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
> [INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
> [INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
> [INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
> [INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
> [INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
> [INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
> [INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
> [INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
> [INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
> [INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
> [INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
> [INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
> [INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
> [INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
> [INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
> [INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
> [INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
> [INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
> [INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
> [INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
> [INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
> [INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
> [INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
> [INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
> [INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
> [INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
> [INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
> [INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
> [INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
> [INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
> [INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
> [INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
> [INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
> [INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
> [INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:00 min
>
>
> Thanks,
>
> Bal�zs Don�t Bessenyei
>
>
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/#review146268
-----------------------------------------------------------
Please remove all non-essential changes, spurious whitespace modifications, etc. Then resubmit.
- Mike Percy
On Aug. 18, 2016, 2:37 a.m., Bal�zs Don�t Bessenyei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51200/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2016, 2:37 a.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Changes in FLUME-2318 broke some tests that have empty files
>
>
> Diffs
> -----
>
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
> flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
>
> Diff: https://reviews.apache.org/r/51200/diff/
>
>
> Testing
> -------
>
> [INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
> [INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
> [INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
> [INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
> [INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
> [INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
> [INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
> [INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
> [INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
> [INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
> [INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
> [INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
> [INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
> [INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
> [INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
> [INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
> [INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
> [INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
> [INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
> [INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
> [INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
> [INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
> [INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
> [INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
> [INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
> [INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
> [INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
> [INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
> [INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
> [INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
> [INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
> [INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
> [INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
> [INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
> [INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
> [INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:00 min
>
>
> Thanks,
>
> Bal�zs Don�t Bessenyei
>
>
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/#review146433
-----------------------------------------------------------
Ship it!
Ship It!
- Mike Percy
On Aug. 21, 2016, 9:07 p.m., Bal�zs Don�t Bessenyei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51200/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2016, 9:07 p.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Changes in FLUME-2318 broke some tests that have empty files
>
>
> Diffs
> -----
>
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
>
> Diff: https://reviews.apache.org/r/51200/diff/
>
>
> Testing
> -------
>
> [INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
> [INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
> [INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
> [INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
> [INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
> [INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
> [INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
> [INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
> [INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
> [INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
> [INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
> [INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
> [INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
> [INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
> [INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
> [INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
> [INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
> [INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
> [INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
> [INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
> [INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
> [INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
> [INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
> [INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
> [INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
> [INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
> [INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
> [INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
> [INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
> [INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
> [INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
> [INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
> [INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
> [INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
> [INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
> [INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:00 min
>
>
> Thanks,
>
> Bal�zs Don�t Bessenyei
>
>
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 4:07 a.m.)
Review request for Flume and Mike Percy.
Repository: flume-git
Description
-------
Changes in FLUME-2318 broke some tests that have empty files
Diffs (updated)
-----
i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
Diff: https://reviews.apache.org/r/51200/diff/
Testing
-------
[INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
[INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
[INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
[INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
[INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
[INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
[INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
[INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
[INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
[INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
[INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
[INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
[INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
[INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
[INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
[INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
[INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
[INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
[INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
[INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
[INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
[INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
[INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
[INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
[INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
[INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
[INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
[INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
[INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
[INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
[INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
[INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
[INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
[INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
[INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
[INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:00 min
Thanks,
Bal�zs Don�t Bessenyei
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
> On Aug. 21, 2016, 10:57 p.m., Mike Percy wrote:
> > i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java, line 424
> > <https://reviews.apache.org/r/51200/diff/2/?file=1480245#file1480245line424>
> >
> > Looks good, but let's be a little more strict here with our verification. How about this?
> >
> > // Skip over first file, which is empty, and will return an empty event.
> > Event event = parser.readEvent();
> > assertEquals(0, event.getBody().length);
Done. Thanks for the advice!
- Bal�zs Don�t
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/#review146274
-----------------------------------------------------------
On Aug. 22, 2016, 4:07 a.m., Bal�zs Don�t Bessenyei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51200/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 4:07 a.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Changes in FLUME-2318 broke some tests that have empty files
>
>
> Diffs
> -----
>
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
>
> Diff: https://reviews.apache.org/r/51200/diff/
>
>
> Testing
> -------
>
> [INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
> [INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
> [INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
> [INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
> [INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
> [INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
> [INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
> [INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
> [INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
> [INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
> [INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
> [INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
> [INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
> [INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
> [INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
> [INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
> [INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
> [INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
> [INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
> [INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
> [INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
> [INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
> [INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
> [INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
> [INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
> [INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
> [INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
> [INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
> [INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
> [INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
> [INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
> [INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
> [INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
> [INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
> [INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
> [INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:00 min
>
>
> Thanks,
>
> Bal�zs Don�t Bessenyei
>
>
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/#review146274
-----------------------------------------------------------
i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java (line 424)
<https://reviews.apache.org/r/51200/#comment212650>
Looks good, but let's be a little more strict here with our verification. How about this?
// Skip over first file, which is empty, and will return an empty event.
Event event = parser.readEvent();
assertEquals(0, event.getBody().length);
- Mike Percy
On Aug. 21, 2016, 2:58 p.m., Bal�zs Don�t Bessenyei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51200/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2016, 2:58 p.m.)
>
>
> Review request for Flume and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Changes in FLUME-2318 broke some tests that have empty files
>
>
> Diffs
> -----
>
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
> i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
>
> Diff: https://reviews.apache.org/r/51200/diff/
>
>
> Testing
> -------
>
> [INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
> [INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
> [INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
> [INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
> [INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
> [INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
> [INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
> [INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
> [INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
> [INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
> [INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
> [INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
> [INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
> [INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
> [INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
> [INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
> [INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
> [INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
> [INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
> [INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
> [INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
> [INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
> [INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
> [INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
> [INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
> [INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
> [INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
> [INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
> [INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
> [INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
> [INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
> [INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
> [INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
> [INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
> [INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
> [INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:00 min
>
>
> Thanks,
>
> Bal�zs Don�t Bessenyei
>
>
Re: Review Request 51200: FLUME-2974: Some tests are broken in
TestReliableSpoolingFileEventReader and TestSpoolingFileLineReader
Posted by Balázs Donát Bessenyei <be...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51200/
-----------------------------------------------------------
(Updated Aug. 21, 2016, 9:58 p.m.)
Review request for Flume and Mike Percy.
Repository: flume-git
Description
-------
Changes in FLUME-2318 broke some tests that have empty files
Diffs (updated)
-----
i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java fdc3ce9
i/flume-ng-core/src/test/java/org/apache/flume/client/avro/TestSpoolingFileLineReader.java ac046a9
Diff: https://reviews.apache.org/r/51200/diff/
Testing
-------
[INFO] Flume checkstyle project ........................... SUCCESS [ 0.900 s]
[INFO] Apache Flume ....................................... SUCCESS [ 2.415 s]
[INFO] Flume NG SDK ....................................... SUCCESS [01:17 min]
[INFO] Flume NG Configuration ............................. SUCCESS [ 2.325 s]
[INFO] Flume Auth ......................................... SUCCESS [ 9.019 s]
[INFO] Flume NG Core ...................................... SUCCESS [08:09 min]
[INFO] Flume NG Sinks ..................................... SUCCESS [ 0.289 s]
[INFO] Flume NG HDFS Sink ................................. SUCCESS [02:13 min]
[INFO] Flume NG IRC Sink .................................. SUCCESS [ 1.874 s]
[INFO] Flume NG Channels .................................. SUCCESS [ 0.264 s]
[INFO] Flume NG JDBC channel .............................. SUCCESS [ 32.233 s]
[INFO] Flume NG file-based channel ........................ SUCCESS [05:04 min]
[INFO] Flume NG Spillable Memory channel .................. SUCCESS [ 40.227 s]
[INFO] Flume NG Node ...................................... SUCCESS [ 42.571 s]
[INFO] Flume NG Embedded Agent ............................ SUCCESS [ 20.504 s]
[INFO] Flume NG HBase Sink ................................ SUCCESS [04:59 min]
[INFO] Flume NG ElasticSearch Sink ........................ SUCCESS [01:06 min]
[INFO] Flume NG Morphline Solr Sink ....................... SUCCESS [ 19.048 s]
[INFO] Flume Kafka Sink ................................... SUCCESS [ 17.911 s]
[INFO] Flume NG Kite Dataset Sink ......................... SUCCESS [ 13.450 s]
[INFO] Flume NG Hive Sink ................................. SUCCESS [ 55.149 s]
[INFO] Flume Sources ...................................... SUCCESS [ 0.260 s]
[INFO] Flume Scribe Source ................................ SUCCESS [ 4.776 s]
[INFO] Flume JMS Source ................................... SUCCESS [ 14.222 s]
[INFO] Flume Twitter Source ............................... SUCCESS [ 2.183 s]
[INFO] Flume Kafka Source ................................. SUCCESS [01:27 min]
[INFO] Flume Taildir Source ............................... SUCCESS [ 17.298 s]
[INFO] flume-kafka-channel ................................ SUCCESS [03:04 min]
[INFO] Flume legacy Sources ............................... SUCCESS [ 0.262 s]
[INFO] Flume legacy Avro source ........................... SUCCESS [ 2.599 s]
[INFO] Flume legacy Thrift Source ......................... SUCCESS [ 3.021 s]
[INFO] Flume NG Clients ................................... SUCCESS [ 0.218 s]
[INFO] Flume NG Log4j Appender ............................ SUCCESS [ 26.838 s]
[INFO] Flume NG Tools ..................................... SUCCESS [ 2.734 s]
[INFO] Flume NG distribution .............................. SUCCESS [ 6.710 s]
[INFO] Flume NG Integration Tests ......................... SUCCESS [01:58 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:00 min
Thanks,
Bal�zs Don�t Bessenyei