You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/24 04:29:14 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull
request #81: [YUNIKORN-28] Support validating yunikorn-configs before
admitting it
wilfred-s commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r396896583
##########
File path: pkg/plugin/admissioncontrollers/webhook/admission_controller_test.go
##########
@@ -211,3 +214,20 @@ func TestUpdateSchedulerName(t *testing.T) {
}
}
+func TestValidateConfigMap(t *testing.T) {
+ configName := fmt.Sprintf("%s.yaml", conf.DefaultPolicyGroup)
+ controller := &admissionController{
+ configName: configName,
+ }
+ configmap := &v1.ConfigMap{
+ ObjectMeta: metav1.ObjectMeta{
+ Name: common.DefaultConfigMapName,
+ },
+ Data: make(map[string]string),
Review comment:
check `go fmt` for this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org