You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/06 17:48:13 UTC

[jira] Created: (CASSANDRA-56) Minor cleanup & unused code removal

Minor cleanup & unused code removal
-----------------------------------

                 Key: CASSANDRA-56
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
             Project: Cassandra
          Issue Type: Bug
            Reporter: Jonathan Ellis
            Priority: Minor




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-56) Minor cleanup & unused code removal

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-56:
------------------------------------

    Attachment: 0002-r-m-redundant-or-unused-code.patch

> Minor cleanup & unused code removal
> -----------------------------------
>
>                 Key: CASSANDRA-56
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-replace-.indexOf-1-with-.contains.patch, 0002-r-m-redundant-or-unused-code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-56) Minor cleanup & unused code removal

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-56:
---------------------------------------

    Assignee: Jonathan Ellis

> Minor cleanup & unused code removal
> -----------------------------------
>
>                 Key: CASSANDRA-56
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-replace-.indexOf-1-with-.contains.patch, 0002-r-m-redundant-or-unused-code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-56) Minor cleanup & unused code removal

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-56.
-------------------------------------

    Resolution: Fixed

committed

> Minor cleanup & unused code removal
> -----------------------------------
>
>                 Key: CASSANDRA-56
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-replace-.indexOf-1-with-.contains.patch, 0002-r-m-redundant-or-unused-code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-56) Minor cleanup & unused code removal

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-56:
------------------------------------

    Attachment: 0001-replace-.indexOf-1-with-.contains.patch

> Minor cleanup & unused code removal
> -----------------------------------
>
>                 Key: CASSANDRA-56
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-replace-.indexOf-1-with-.contains.patch, 0002-r-m-redundant-or-unused-code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-56) Minor cleanup & unused code removal

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696171#action_12696171 ] 

Johan Oskarsson commented on CASSANDRA-56:
------------------------------------------

+1 for patch 0001, much clearer.
+1 for 0002 too, but personally I don't mind explicitly setting variables to null. ColumnFamilyStore:955 is incorrectly indented, but it was like that before this patch too.

> Minor cleanup & unused code removal
> -----------------------------------
>
>                 Key: CASSANDRA-56
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-56
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-replace-.indexOf-1-with-.contains.patch, 0002-r-m-redundant-or-unused-code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.