[GitHub] [airflow] aru-trackunit commented on a diff in pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

["aru-trackunit (via GitHub)" <gi...@apache.org>]

aru-trackunit commented on code in PR #29694:
URL: https://github.com/apache/airflow/pull/29694#discussion_r1118430932


##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -243,8 +284,13 @@ def upload_file(
             .create(body=file_metadata, media_body=media, fields="id", supportsAllDrives=True)
             .execute(num_retries=self.num_retries)
         )
-        self.log.info("File %s uploaded to gdrive://%s.", local_location, remote_location)
-        return file.get("id")
+        file_id = file.get("id")
+
+        upload_location = (

Review Comment:
   @dimberman I have tested your first scenario. Google API doesn't return more `parents` than user can see. So having path: `/Drive/FolderA/FolderB/file.csv` and user is granted access to `FolderB` then what he sees is `/FolderB/file.csv` which makes sense because this is what he sees on the UI as well.
   
   I do agree that for performance reasons it is nice to switch it off when needed in case someone has a large tree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org