You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "labuladong (via GitHub)" <gi...@apache.org> on 2023/01/31 05:48:58 UTC
[GitHub] [pulsar-site] labuladong opened a new pull request, #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
labuladong opened a new pull request, #394:
URL: https://github.com/apache/pulsar-site/pull/394
The document update of https://github.com/apache/pulsar/pull/19300
Please review this pr only if https://github.com/apache/pulsar/pull/19300 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#discussion_r1095308078
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
+| `-l`, `--limit` | If you set backlog quota type to `destination_storage`, this parameter can set the backlog size limit (for example `10M` or `16G`), non-positive number for disabling size limit. ||
+| `-lt`, `--limitTime` | If you set backlog quota type to `message_age`, this parameter can set the time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. ||
+| `-p`, `--policy` | The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction` |
Review Comment:
```suggestion
| `-p`, `--policy` | The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception`, and `consumer_backlog_eviction`. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #394:
URL: https://github.com/apache/pulsar-site/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#discussion_r1095306654
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
Review Comment:
```suggestion
| `-t`, `--type` | The backlog quota type. The valid options are: `destination_storage` and `message_age`. | destination_storage |
```
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
+| `-l`, `--limit` | If you set backlog quota type to `destination_storage`, this parameter can set the backlog size limit (for example `10M` or `16G`), non-positive number for disabling size limit. ||
Review Comment:
```suggestion
| `-l`, `--limit` | If the backlog quota type is set to `destination_storage`, you can use this parameter to set the backlog size limit (for example, `10M` or `16G`). To disable the size limit, use a non-positive number. ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] labuladong commented on pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "labuladong (via GitHub)" <gi...@apache.org>.
labuladong commented on PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#issuecomment-1414706275
This pr is ready to merge @Anonymitaet @momo-jun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#discussion_r1095307824
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
+| `-l`, `--limit` | If you set backlog quota type to `destination_storage`, this parameter can set the backlog size limit (for example `10M` or `16G`), non-positive number for disabling size limit. ||
+| `-lt`, `--limitTime` | If you set backlog quota type to `message_age`, this parameter can set the time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. ||
Review Comment:
```suggestion
| `-lt`, `--limitTime` | If the backlog quota type is set to `message_age`, you can use this parameter to set the time limit in seconds (or minutes, hours, days, weeks, e.g., 100m, 3h, 2d, 5w). To disable the time limit, use a non-positive number. ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#discussion_r1095306953
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
+| `-l`, `--limit` | If you set backlog quota type to `destination_storage`, this parameter can set the backlog size limit (for example `10M` or `16G`), non-positive number for disabling size limit. ||
+| `-lt`, `--limitTime` | If you set backlog quota type to `message_age`, this parameter can set the time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. ||
+| `-p`, `--policy` | The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction` |
+
+If you want set both time limit and size limit, you can set them separately.
Review Comment:
```suggestion
If you want to set both the time limit and the size limit, you need to set them separately.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #394: [improve][doc] improve `pulsar-admin namespaces set-backlog-quota`
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #394:
URL: https://github.com/apache/pulsar-site/pull/394#discussion_r1095306709
##########
docs/reference-pulsar-admin.md:
##########
@@ -1240,26 +1240,29 @@ pulsar-admin namespaces set-backlog-quota tenant/namespace options
Options
-|Flag|Description|Default|
-|----|---|---|
-|`-l`, `--limit`|The backlog size limit (for example `10M` or `16G`)||
-|`-lt`, `--limitTime`|Time limit in second (or minutes, hours, days, weeks eg: 100m, 3h, 2d, 5w), non-positive number for disabling time limit. (for example 3600 for 1 hour)||
-|`-p`, `--policy`|The retention policy to enforce when the limit is reached. The valid options are: `producer_request_hold`, `producer_exception` or `consumer_backlog_eviction`|
-|`-t`, `--type`|Backlog quota type to set. The valid options are: `destination_storage`, `message_age` |destination_storage|
+| Flag | Description | Default |
+|----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------|
+| `-t`, `--type` | Backlog quota type to set. The valid options are: `destination_storage`, `message_age` | destination_storage |
+| `-l`, `--limit` | If you set backlog quota type to `destination_storage`, this parameter can set the backlog size limit (for example `10M` or `16G`), non-positive number for disabling size limit. ||
Review Comment:
```suggestion
| `-l`, `--limit` | If the backlog quota type is set to `destination_storage`, you can use this parameter to set the backlog size limit (for example, `10MB` or `16GB`). To disable the size limit, use a non-positive number. ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org