You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/23 14:46:13 UTC

[GitHub] [incubator-streampark] wangsizhu0504 opened a new pull request, #1892: [Improve]: Improve page style, adjust API interface,fix page jump bug

wangsizhu0504 opened a new pull request, #1892:
URL: https://github.com/apache/incubator-streampark/pull/1892

   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Issue Number: close [#1884](https://github.com/apache/incubator-streampark/issues/1884)<!-- REMOVE this line if no issue to close -->
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes / no) yes
    
   
   - [x] 1.newui part of the page console error reporting
   - [x] 2.The application page owner drop-down box is not displayed
   
   <img width="1662" alt="iShot_2022-10-23_22 29 35" src="https://user-images.githubusercontent.com/39726513/197397847-6632a415-3756-4e47-a188-fead52f0600c.png">
   
   - [x] 3.team The dropdown box is too big, the style needs to be adjusted
   
   <img width="327" alt="iShot_2022-10-23_22 38 43" src="https://user-images.githubusercontent.com/39726513/197398328-100e12a4-3c82-4e73-9658-31aad70e9497.png">
   
   - [x] 4.operation Width is too narrow, need to adjust the width
   
   <img width="1438" alt="iShot_2022-10-23_22 34 08" src="https://user-images.githubusercontent.com/39726513/197398044-b8eb862b-884d-4123-9cfc-7b81953b8cb7.png">
   
   (All table operation columns are now 200 wide by default)
   
   - [x] 5.Status, build, etc. in the application page Display style needs to be adjusted (tag component style)
   
   <img width="237" alt="iShot_2022-10-23_22 39 37" src="https://user-images.githubusercontent.com/39726513/197398383-ece5248d-de79-4fe2-889d-73c0f2144cf5.png">
   
   (remove border-radius ,add font weight)
   - [x] 6.The right side of the application page. Form helper function, remove multi-selection
   
   <img width="386" alt="iShot_2022-10-23_22 40 39" src="https://user-images.githubusercontent.com/39726513/197398443-9f65f73a-43c9-4ab0-ad80-d850a7c17b88.png">
   
   - [x] 7.The table element is left-aligned by default
   - [x]  8. application Edit page, element is too crowded, need to adjust the width
   
   <img width="1123" alt="iShot_2022-10-23_22 42 01" src="https://user-images.githubusercontent.com/39726513/197398521-58ce1739-07f6-4e6d-8f38-479168d3e4ad.png">
   
   - [x] 9.alert is consistent with the old UI component (sweetalert2 component)
   
   <img width="1450" alt="iShot_2022-10-23_22 43 12" src="https://user-images.githubusercontent.com/39726513/197398570-c398634f-3eb3-47e4-bdb9-95a8aa54f46b.png">
   
   -[x] 10.Style issues related to pop-up windows
   
   <img width="558" alt="iShot_2022-10-23_22 45 11" src="https://user-images.githubusercontent.com/39726513/197398709-eda3fb17-6adf-4a83-8562-69bdc7d1b2ab.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys merged pull request #1892: [Improve]: Improve page style, adjust API interface,fix page jump bug

Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1892:
URL: https://github.com/apache/incubator-streampark/pull/1892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org