You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/10 15:57:48 UTC

[GitHub] [pulsar] phijohns-tibco opened a new pull request #9165: [Issue 9155][build]Fixing the mac build if you use a different openssl

phijohns-tibco opened a new pull request #9165:
URL: https://github.com/apache/pulsar/pull/9165


   Fixes #9155
   
   ### Motivation
   When I attempted to build the c library on macosx with openssl 1.1.1i it failed with linkage errors. I tracked those errors down to the fact that the OPENSLL_ROOT_DIR was incorrect outside of mac vms used by the upstream.
   
   ### Modifications
   
   I set the default value first and then reset it only if running on mac.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   No
   
   ### Documentation
   
     -None


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9165: [Issue 9155][build]Fixing the mac build if you use a different openssl

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9165:
URL: https://github.com/apache/pulsar/pull/9165#issuecomment-757561656


   @BewareMyPower Please help review this PR
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #9165: [Issue 9155][build]Fixing the mac build if you use a different openssl

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9165:
URL: https://github.com/apache/pulsar/pull/9165#issuecomment-758322564


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9165: [Issue 9155][build]Fixing the mac build if you use a different openssl

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9165:
URL: https://github.com/apache/pulsar/pull/9165


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #9165: [Issue 9155][build]Fixing the mac build if you use a different openssl

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9165:
URL: https://github.com/apache/pulsar/pull/9165


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org