[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #404: Add support for Proxy Protocol V2

["tomaswolf (via GitHub)" <gi...@apache.org>]

tomaswolf commented on code in PR #404:
URL: https://github.com/apache/mina-sshd/pull/404#discussion_r1313454310


##########
sshd-contrib/pom.xml:
##########
@@ -80,6 +80,16 @@
             <type>test-jar</type>
             <scope>test</scope>
         </dependency>
+		<dependency>
+			<groupId>org.mockito</groupId>
+			<artifactId>mockito-core</artifactId>
+			<scope>test</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.assertj</groupId>
+			<artifactId>assertj-core</artifactId>
+			<version>3.24.2</version>
+		</dependency>

Review Comment:
   Indentation. Please use 4 spaces.



##########
sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java:
##########
@@ -292,6 +292,10 @@ public short getShort() {
         return v;
     }
 
+	public int getUShort() {
+		return getShort() & 0xFFFF;
+	}
+

Review Comment:
   Something wrong with the indentation. TAB vs. 4 spaces? Apache MINA sshd uses spaces throughout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org