[jira] [Created] (HBASE-22292) PreemptiveFastFailInterceptor clean repeatedFailuresMap issue

["zou (JIRA)" <ji...@apache.org>]

zou created HBASE-22292:
---------------------------

             Summary: PreemptiveFastFailInterceptor clean repeatedFailuresMap issue
                 Key: HBASE-22292
                 URL: https://issues.apache.org/jira/browse/HBASE-22292
             Project: HBase
          Issue Type: Bug
            Reporter: zou


PreemptiveFastFailInterceptor do not set fastFailClearingTimeMilliSec, so in 

occasionallyCleanupFailureInformation function this branch
{code:java}
else if (now > entry.getValue().timeOfFirstFailureMilliSec
    + this.fastFailClearingTimeMilliSec) {{code}
will be always be true,then the repeatedFailuresMap will be clean.

and in the constructor function 
{code:java}
public PreemptiveFastFailInterceptor(Configuration conf) {
  this.fastFailThresholdMilliSec = conf.getLong(
      HConstants.HBASE_CLIENT_FAST_FAIL_THREASHOLD_MS,
      HConstants.HBASE_CLIENT_FAST_FAIL_THREASHOLD_MS_DEFAULT);
  this.failureMapCleanupIntervalMilliSec = conf.getLong(
// this constant seem to set fastFailClearingTimeMilliSec, it may be a mistake.
      HConstants.HBASE_CLIENT_FAST_FAIL_CLEANUP_MS_DURATION_MS,
      HConstants.HBASE_CLIENT_FAST_FAIL_CLEANUP_DURATION_MS_DEFAULT);
  lastFailureMapCleanupTimeMilliSec = EnvironmentEdgeManager.currentTime();
}
{code}
 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)