You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2026/09/12 00:51:42 UTC

[Bug 8415] New: FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

            Bug ID: 8415
           Summary: FreeMail plugin strips addresses from the shared
                    rendered body array, corrupting body rules that run
                    after it
           Product: Spamassassin
           Version: 4.0.2
          Hardware: PC
                OS: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: kent@mxguardian.net
  Target Milestone: Undefined

FreeMail::_parse_body() harvests addresses from the body and, before
scanning, blanks out addresses it doesn't want to count. That's reasonable,
but it does it in place on the array returned by
get_decoded_stripped_body_text_array(), which is the message's *cached*
rendered body. "foreach (@$body)" aliases $_ to the live elements, so the
s/// calls permanently rewrite the body for every rule that runs afterward.

Net effect: any body rule evaluated after FreeMail sees a corrupted body.
Three things are destroyed: addresses in <>; bare addresses followed by a
short lowercase word and a colon, *along with that trailing word*; and any
URL containing @ or %40. Forwarded mail is hit the hardest.

Examples:

From: Jane Doe <ja...@example.com>      ->  From: Jane Doe
To: jane@example.com Subject: hi       ->  To:   hi
On Mon, jane@example.com wrote:        ->  On Mon,

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8415] FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

Kent Oyer <ke...@mxguardian.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Kent Oyer <ke...@mxguardian.net> ---
Sending        lib/Mail/SpamAssassin/Plugin/FreeMail.pm
Transmitting file data .done
Committing transaction...
Committed revision 1938338.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8415] FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

Kent Oyer <ke...@mxguardian.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kent@mxguardian.net

--- Comment #1 from Kent Oyer <ke...@mxguardian.net> ---
Created attachment 6080
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=6080&action=edit
make a copy before stripping addresses

patch attached

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8415] FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

--- Comment #3 from Kent Oyer <ke...@mxguardian.net> ---
We need one more yes vote to commit this

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8415] FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovanni@paclan.it

--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
+1 to commit, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8415] FreeMail plugin strips addresses from the shared rendered body array, corrupting body rules that run after it

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8415

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sidney@sidney.com

--- Comment #4 from Sidney Markowitz <si...@sidney.com> ---
+1 to commit

-- 
You are receiving this mail because:
You are the assignee for the bug.