You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/09/27 04:53:56 UTC

[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1696: [Feature] Split each version of sql-upgrade.sql into a different directory

1996fanrui commented on PR #1696:
URL: https://github.com/apache/incubator-streampark/pull/1696#issuecomment-1258977268

   > @1996fanrui @wolfboys Do we need to split sql into DDL, DML?
   
   Hi @xinzhuxiansheng thanks for your review. Discussed with @wolfboys , we decided to merge dml and ddl into one file for two reasons:
   
   1. It's convenient for user to execute them.
   2. Splitting into two files may have bugs in some scenarios. E.g:
   - Create B-table (DDL)
   - Migrate table A data to new table B (DML)
   - Delete the obsolete fields of A table (DDL)
   
   That's, scenarios where DML is executed between multiple DDLs may have bugs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org