You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/07 14:04:30 UTC

[GitHub] [tvm] d-smirnov opened a new pull request #8004: [Relay][dismantler] Added handling of packed func

d-smirnov opened a new pull request #8004:
URL: https://github.com/apache/tvm/pull/8004


   Added handling of CallNode objects created via packed functions invocation + test cases. Related to #7832
   @mbrookhart
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart commented on pull request #8004: [Relay][dismantler] Added handling of packed func

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8004:
URL: https://github.com/apache/tvm/pull/8004#issuecomment-843409103


   Can you add some comments to the code to explain what this is doing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart commented on pull request #8004: [Relay][dismantler] Added handling of packed func

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8004:
URL: https://github.com/apache/tvm/pull/8004#issuecomment-848084631


   Thanks @d-smirnov 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] d-smirnov commented on pull request #8004: [Relay][dismantler] Added handling of packed func

Posted by GitBox <gi...@apache.org>.
d-smirnov commented on pull request #8004:
URL: https://github.com/apache/tvm/pull/8004#issuecomment-834509498


   There is a need to preform additional action and to preserve original deleter as well, hence an extra field for CallNode


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart commented on pull request #8004: [Relay][dismantler] Added handling of packed func

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8004:
URL: https://github.com/apache/tvm/pull/8004#issuecomment-834497765


   Can you add some comments to this? It's not clear why there need to be multiple deleter attributes in the CallNode class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbrookhart merged pull request #8004: [Relay][dismantler] Added handling of packed func

Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8004:
URL: https://github.com/apache/tvm/pull/8004


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org