[jira] [Issue Comment Deleted] (TS-2279) proxy.config.exec_thread.affinity's values

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-2279:
------------------------------

    Comment: was deleted

(was: As we discussed a few times, it feels that with the new life cycles in traffic_server, some of this could move over there. Such as, traffic_server knows when it's ready to serve requests (proxy), and maybe that should trigger the start of external health checks and monitoring. A good question was brought up, in that you don't want a life cycle to be allowed to take arbitrarily long time, but that can probably be configured and managed in traffic_server itself, such that it won't allow a certain life cycle to take too long.

Basically, simplify traffic_cop (maybe even eliminate all / most of it), in favor of using Linux tools, and more intelligence in traffic_server itself.)

> proxy.config.exec_thread.affinity's values
> ------------------------------------------
>
>                 Key: TS-2279
>                 URL: https://issues.apache.org/jira/browse/TS-2279
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: Igor Galić
>            Assignee: Phil Sorber
>             Fix For: 5.1.0
>
>
> The setting of {{proxy.config.exec_thread.affinity}} only has an affect when traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at all, not even a warning about its being ineffectual when setting that value while trafficserver is *not* configured with {{--enable-hwloc}}.
> Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
> {code}
>  {RECT_CONFIG, "proxy.config.exec_thread.affinity", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
> {code}
> but the code uses a range of [0-3]:
> {code}
> #if TS_USE_HWLOC
>     if (affinity != 0) {
>       int logical_ratio;
>       switch(affinity) {
>       case 3:           // assign threads to logical cores
>         logical_ratio = 1;
>         break;
>       case 2:           // assign threads to real cores
>         logical_ratio = pu / cu;
>         break;
>       case 1:           // assign threads to sockets
>       default:
>         logical_ratio = pu / socket;
>       }
> {code}
> And finally, 1 is the default value, rather than issuing a warning about an incorrect value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)