[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4021: [TE] add exceptions for detector API

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4021: [TE] add exceptions for detector API
URL: https://github.com/apache/incubator-pinot/pull/4021#discussion_r269688901
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineJob.java
 ##########
 @@ -95,6 +95,7 @@ public void execute(JobExecutionContext jobExecutionContext) throws JobExecution
     taskDTO.setJobName(jobName);
     taskDTO.setStatus(TaskConstants.TaskStatus.WAITING);
     taskDTO.setTaskInfo(taskInfoJson);
+    taskDTO.setJobId(id);
 
 Review comment:
   We no longer store job in the database. This id is the detection config id. Setting it might cause side effects.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org