You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/11/10 04:40:00 UTC
[incubator-echarts] branch enhance-type updated: fix(types): fix
some types issue
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch enhance-type
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/enhance-type by this push:
new 67d6a33 fix(types): fix some types issue
67d6a33 is described below
commit 67d6a338ea9368ae17177ee6c262db9699554e2e
Author: pissang <bm...@gmail.com>
AuthorDate: Tue Nov 10 12:39:15 2020 +0800
fix(types): fix some types issue
---
src/chart/bar/BaseBarSeries.ts | 5 +++--
src/component/brush/BrushModel.ts | 16 ++++++++--------
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/chart/bar/BaseBarSeries.ts b/src/chart/bar/BaseBarSeries.ts
index 39c404e..c39252a 100644
--- a/src/chart/bar/BaseBarSeries.ts
+++ b/src/chart/bar/BaseBarSeries.ts
@@ -23,14 +23,15 @@ import {
SeriesOption,
SeriesOnCartesianOptionMixin,
SeriesOnPolarOptionMixin,
- ScaleDataValue
+ ScaleDataValue,
+ DefaultExtraStateOpts
} from '../../util/types';
import GlobalModel from '../../model/Global';
import Cartesian2D from '../../coord/cartesian/Cartesian2D';
import List from '../../data/List';
-export interface BaseBarSeriesOption<StateOption, ExtraStateOption = unknown>
+export interface BaseBarSeriesOption<StateOption, ExtraStateOption = DefaultExtraStateOpts>
extends SeriesOption<StateOption, ExtraStateOption>,
SeriesOnCartesianOptionMixin,
SeriesOnPolarOptionMixin {
diff --git a/src/component/brush/BrushModel.ts b/src/component/brush/BrushModel.ts
index 8364e6f..0172afa 100644
--- a/src/component/brush/BrushModel.ts
+++ b/src/component/brush/BrushModel.ts
@@ -105,15 +105,15 @@ export interface BrushOption extends ComponentOption, ModelFinderObject {
// --- Current painting brush options ---
// Default type of brush
- brushType: BrushTypeUncertain;
- brushStyle: {
- borderWidth: number;
- color: ZRColor;
- borderColor: ZRColor;
+ brushType?: BrushTypeUncertain;
+ brushStyle?: {
+ borderWidth?: number;
+ color?: ZRColor;
+ borderColor?: ZRColor;
};
- transformable: boolean;
- brushMode: BrushMode;
- removeOnClick: boolean;
+ transformable?: boolean;
+ brushMode?: BrushMode;
+ removeOnClick?: boolean;
}
class BrushModel extends ComponentModel<BrushOption> {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org