You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/24 00:00:03 UTC
[GitHub] [spark] sunchao opened a new pull request #34085: [SPARK-36835] Enable createDependencyReducedPom for Maven shaded plugin
sunchao opened a new pull request #34085:
URL: https://github.com/apache/spark/pull/34085
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Enable `createDependencyReducedPom` for Spark's Maven shaded plugin so that the effective pom won't contain those shaded artifacts such as `org.eclipse.jetty`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
At the moment, the effective pom leaks transitive dependencies to downstream apps for those shaded artifacts, which potentially will cause issues.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I manually tested and the `core/dependency-reduced-pom.xml` no longer contains dependencies such as `jetty-XX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926280484
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34085: [SPARK-36835] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926247715
Local build looks good, and let's see how Spark CI reacts. cc @JoshRosen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926746395
@sunchao @JoshRosen I find that after merging this PR, Spark can't build with Hadoop2.7. The build hangs for over 1 hour
```
$ ./build/mvn clean package -DskipTests -B -Pmesos -Pyarn -Pkubernetes -Psparkr -Pscala-2.12 -Phadoop-2.7 -Phive -Phive-thriftserver
...
[WARNING] spark-launcher_2.12-3.2.1-SNAPSHOT.jar, unused-1.0.0.jar define 1 overlapping resource:
[WARNING] - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /Users/gengliangwang/projects/spark/launcher/target/spark-launcher_2.12-3.2.1-SNAPSHOT.jar with /Users/gengliangwang/projects/spark/launcher/target/spark-launcher_2.12-3.2.1-SNAPSHOT-shaded.jar
[INFO] Dependency-reduced POM written at: /Users/gengliangwang/projects/spark/launcher/dependency-reduced-pom.xml
```
Could you help fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926252427
**[Test build #143574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143574/testReport)** for PR 34085 at commit [`08b1f31`](https://github.com/apache/spark/commit/08b1f31a7587cc8536b8a672b0a390ab6618bb97).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926288169
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926320990
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926306969
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143574/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926306969
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143574/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926753257
@gengliangwang Oops, I'm taking a look on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926746395
@sunchao @JoshRosen I find that after merging this PR, Spark can't build with Hadoop2.7. The build hangs for over 1 hour
```
$ ./build/mvn clean package -DskipTests -B -Pmesos -Pyarn -Pkubernetes -Psparkr -Pscala-2.12 -Phadoop-2.7 -Phive -Phive-thriftserver
...
[WARNING] spark-launcher_2.12-3.2.0.jar, unused-1.0.0.jar define 1 overlapping resource:
[WARNING] - META-INF/MANIFEST.MF
[WARNING] maven-shade-plugin has detected that some class files are
[WARNING] present in two or more JARs. When this happens, only one
[WARNING] single version of the class is copied to the uber jar.
[WARNING] Usually this is not harmful and you can skip these warnings,
[WARNING] otherwise try to manually exclude artifacts based on
[WARNING] mvn dependency:tree -Ddetail=true and the above output.
[WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing /opt/spark-rm/output/spark-3.2.0-bin-hadoop2.7/launcher/target/spark-launcher_2.12-3.2.0.jar with /opt/spark-rm/output/spark-3.2.0-bin-hadoop2.7/launcher/target/spark-launcher_2.12-3.2.0-shaded.jar
[INFO] Dependency-reduced POM written at: /opt/spark-rm/output/spark-3.2.0-bin-hadoop2.7/launcher/dependency-reduced-pom.xml
```
Could you help fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926783130
I opened #34100 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926288169
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #34085:
URL: https://github.com/apache/spark/pull/34085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926766345
Yes this is the reason that last time I disabled the config. I think we are running into some Maven bug that is similar to [this one](https://issues.apache.org/jira/browse/MSHADE-148). To fix it, I think we can put the newly introduced
```
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>${hadoop-client-runtime.artifact}</artifactId>
<version>${hadoop.version}</version>
<scope>test</scope>
</dependency>
```
in `launcher/pom.xml` to a `hadoop-3.2` profile section. Tested locally and this is working. Let me see if other modules have similar issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926252427
**[Test build #143574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143574/testReport)** for PR 34085 at commit [`08b1f31`](https://github.com/apache/spark/commit/08b1f31a7587cc8536b8a672b0a390ab6618bb97).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926305859
**[Test build #143574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143574/testReport)** for PR 34085 at commit [`08b1f31`](https://github.com/apache/spark/commit/08b1f31a7587cc8536b8a672b0a390ab6618bb97).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926291898
Thanks, merging to master and branch-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34085: [SPARK-36835][BUILD] Enable createDependencyReducedPom for Maven shaded plugin
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34085:
URL: https://github.com/apache/spark/pull/34085#issuecomment-926266718
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org