You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-commits@axis.apache.org by su...@apache.org on 2012/01/20 14:19:56 UTC
svn commit: r1233893 - in
/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail:
MailConstants.java MailTransportSender.java
Author: supun
Date: Fri Jan 20 13:19:55 2012
New Revision: 1233893
URL: http://svn.apache.org/viewvc?rev=1233893&view=rev
Log:
fixing mail attachments
Modified:
axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
Modified: axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
URL: http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java?rev=1233893&r1=1233892&r2=1233893&view=diff
==============================================================================
--- axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java (original)
+++ axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java Fri Jan 20 13:19:55 2012
@@ -60,6 +60,7 @@ public class MailConstants {
public static final String TRANSPORT_MAIL_FORMAT = "transport.mail.Format";
public static final String TRANSPORT_FORMAT_TEXT = "Text";
public static final String TRANSPORT_FORMAT_MP = "Multipart";
+ public static final String TRANSPORT_FORMAT_ATTACHMENT_FILE = "AttachmentFile";
public static final String TRANSPORT_MAIL_FOLDER = "transport.mail.Folder";
public static final String TRANSPORT_MAIL_CONTENT_TYPE = "transport.mail.ContentType";
Modified: axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
URL: http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java?rev=1233893&r1=1233892&r2=1233893&view=diff
==============================================================================
--- axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java (original)
+++ axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java Fri Jan 20 13:19:55 2012
@@ -433,6 +433,15 @@ public class MailTransportSender extends
mimeMultiPart.addBodyPart(mimeBodyPart1);
mimeMultiPart.addBodyPart(mimeBodyPart2);
message.setContent(mimeMultiPart);
+
+ String fileName = (String) msgContext.getProperty(
+ MailConstants.TRANSPORT_FORMAT_ATTACHMENT_FILE);
+ if (fileName != null) {
+ mimeBodyPart2.setFileName(fileName);
+ } else {
+ mimeBodyPart2.setFileName("attachment");
+ }
+
mainPart = mimeBodyPart2;
} else {
mainPart = message;
Re: svn commit: r1233893 - in /axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail:
MailConstants.java MailTransportSender.java
Posted by Supun Kamburugamuva <su...@gmail.com>.
Fixed the issue. Sorry for the trouble.
Supun..
On Fri, Jan 20, 2012 at 10:11 AM, Sagara Gunathunga <
sagara.gunathunga@gmail.com> wrote:
> This commit cause several test failures please take a look
> https://builds.apache.org/job/axis2-transports-trunk/684/
>
> Thanks !
>
> On Fri, Jan 20, 2012 at 6:49 PM, <su...@apache.org> wrote:
>
>> Author: supun
>> Date: Fri Jan 20 13:19:55 2012
>> New Revision: 1233893
>>
>> URL: http://svn.apache.org/viewvc?rev=1233893&view=rev
>> Log:
>> fixing mail attachments
>>
>> Modified:
>>
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
>>
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
>>
>> Modified:
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
>> URL:
>> http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java?rev=1233893&r1=1233892&r2=1233893&view=diff
>>
>> ==============================================================================
>> ---
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
>> (original)
>> +++
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
>> Fri Jan 20 13:19:55 2012
>> @@ -60,6 +60,7 @@ public class MailConstants {
>> public static final String TRANSPORT_MAIL_FORMAT =
>> "transport.mail.Format";
>> public static final String TRANSPORT_FORMAT_TEXT = "Text";
>> public static final String TRANSPORT_FORMAT_MP = "Multipart";
>> + public static final String TRANSPORT_FORMAT_ATTACHMENT_FILE =
>> "AttachmentFile";
>>
>> public static final String TRANSPORT_MAIL_FOLDER =
>> "transport.mail.Folder";
>> public static final String TRANSPORT_MAIL_CONTENT_TYPE =
>> "transport.mail.ContentType";
>>
>> Modified:
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
>> URL:
>> http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java?rev=1233893&r1=1233892&r2=1233893&view=diff
>>
>> ==============================================================================
>> ---
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
>> (original)
>> +++
>> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
>> Fri Jan 20 13:19:55 2012
>> @@ -433,6 +433,15 @@ public class MailTransportSender extends
>> mimeMultiPart.addBodyPart(mimeBodyPart1);
>> mimeMultiPart.addBodyPart(mimeBodyPart2);
>> message.setContent(mimeMultiPart);
>> +
>> + String fileName = (String) msgContext.getProperty(
>> + MailConstants.TRANSPORT_FORMAT_ATTACHMENT_FILE);
>> + if (fileName != null) {
>> + mimeBodyPart2.setFileName(fileName);
>> + } else {
>> + mimeBodyPart2.setFileName("attachment");
>> + }
>> +
>> mainPart = mimeBodyPart2;
>> } else {
>> mainPart = message;
>>
>>
>>
>
>
> --
> Sagara Gunathunga
>
> Blog - http://ssagara.blogspot.com
> Web - http://people.apache.org/~sagara/
> LinkedIn - http://www.linkedin.com/in/ssagara
>
--
Supun Kamburugamuva
Member, Apache Software Foundation; http://www.apache.org
E-mail: supun06@gmail.com <su...@wso2.com>; Mobile: +94 77 431 3585
Blog: http://supunk.blogspot.com
Re: svn commit: r1233893 - in /axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail:
MailConstants.java MailTransportSender.java
Posted by Sagara Gunathunga <sa...@gmail.com>.
This commit cause several test failures please take a look
https://builds.apache.org/job/axis2-transports-trunk/684/
Thanks !
On Fri, Jan 20, 2012 at 6:49 PM, <su...@apache.org> wrote:
> Author: supun
> Date: Fri Jan 20 13:19:55 2012
> New Revision: 1233893
>
> URL: http://svn.apache.org/viewvc?rev=1233893&view=rev
> Log:
> fixing mail attachments
>
> Modified:
>
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
>
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
>
> Modified:
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
> URL:
> http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java?rev=1233893&r1=1233892&r2=1233893&view=diff
>
> ==============================================================================
> ---
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
> (original)
> +++
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailConstants.java
> Fri Jan 20 13:19:55 2012
> @@ -60,6 +60,7 @@ public class MailConstants {
> public static final String TRANSPORT_MAIL_FORMAT =
> "transport.mail.Format";
> public static final String TRANSPORT_FORMAT_TEXT = "Text";
> public static final String TRANSPORT_FORMAT_MP = "Multipart";
> + public static final String TRANSPORT_FORMAT_ATTACHMENT_FILE =
> "AttachmentFile";
>
> public static final String TRANSPORT_MAIL_FOLDER =
> "transport.mail.Folder";
> public static final String TRANSPORT_MAIL_CONTENT_TYPE =
> "transport.mail.ContentType";
>
> Modified:
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
> URL:
> http://svn.apache.org/viewvc/axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java?rev=1233893&r1=1233892&r2=1233893&view=diff
>
> ==============================================================================
> ---
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
> (original)
> +++
> axis/axis2/java/transports/trunk/modules/mail/src/main/java/org/apache/axis2/transport/mail/MailTransportSender.java
> Fri Jan 20 13:19:55 2012
> @@ -433,6 +433,15 @@ public class MailTransportSender extends
> mimeMultiPart.addBodyPart(mimeBodyPart1);
> mimeMultiPart.addBodyPart(mimeBodyPart2);
> message.setContent(mimeMultiPart);
> +
> + String fileName = (String) msgContext.getProperty(
> + MailConstants.TRANSPORT_FORMAT_ATTACHMENT_FILE);
> + if (fileName != null) {
> + mimeBodyPart2.setFileName(fileName);
> + } else {
> + mimeBodyPart2.setFileName("attachment");
> + }
> +
> mainPart = mimeBodyPart2;
> } else {
> mainPart = message;
>
>
>
--
Sagara Gunathunga
Blog - http://ssagara.blogspot.com
Web - http://people.apache.org/~sagara/
LinkedIn - http://www.linkedin.com/in/ssagara