You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/17 12:23:40 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #18520: [improve][build] Add lombok plugin to solve Javadoc issue.
Technoboy- opened a new pull request, #18520:
URL: https://github.com/apache/pulsar/pull/18520
### Motivation
When releasing branch-2.11, there is a issue when generating Javadoc :
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc (default-cli) on project pulsar-functions-api: An error has occurred in Javadoc report generation:
[ERROR] Exit code: 1 - Loading source files for package org.apache.pulsar.functions.api...
[ERROR] Loading source files for package org.apache.pulsar.functions.api.utils...
[ERROR] Loading source files for package org.apache.pulsar.functions.api.state...
[ERROR] Constructing Javadoc information...
[ERROR] /Users/tboy/tboy/workspace_3/pulsar/pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java:173: error: cannot find symbol
[ERROR] <X> FunctionRecord.FunctionRecordBuilder<X> newOutputRecordBuilder(Schema<X> schema);
[ERROR] ^
[ERROR] symbol: class FunctionRecordBuilder
[ERROR] location: class FunctionRecord
[ERROR] /Users/tboy/tboy/workspace_3/pulsar/pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/utils/FunctionRecord.java:52: error: cannot find symbol
[ERROR] public static <T> FunctionRecord.FunctionRecordBuilder<T> from(Context context, Schema<T> schema) {
[ERROR] ^
[ERROR] symbol: class FunctionRecordBuilder
[ERROR] location: class FunctionRecord
[ERROR] 2 errors
[ERROR]
[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk-17.0.3.1.jdk/Contents/Home/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/Users/tboy/tboy/workspace_3/pulsar/pulsar-functions/api-java/target/site/apidocs' dir.
```
We can use `mvn javadoc:javadoc` to reproduce in the master branch.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #18520: [improve][build] Add lombok plugin to solve Javadoc issue.
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #18520:
URL: https://github.com/apache/pulsar/pull/18520#issuecomment-1326297061
@Technoboy- Did this PR solve the issue?
Just wondering about the docs in http://anthonywhitford.com/lombok.maven/lombok-maven-plugin/usage.html:
> Place the java source code with lombok annotations in src/main/lombok (instead of src/main/java). During the build process, the src/main/lombok code will be [delomboked](http://projectlombok.org/features/delombok.html) and the generated java code ends up in target/generated-sources/delombok. The delomboked code is compiled and analysed together with the src/main/java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18520: [improve][build] Add lombok plugin to solve Javadoc issue.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18520:
URL: https://github.com/apache/pulsar/pull/18520#issuecomment-1318630891
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18520?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18520](https://codecov.io/gh/apache/pulsar/pull/18520?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae7edfe) into [master](https://codecov.io/gh/apache/pulsar/commit/aeb4503be59f9a9450dfd47cf5dfcb375735d064?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aeb4503) will **increase** coverage by `5.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18520 +/- ##
============================================
+ Coverage 31.39% 36.80% +5.41%
+ Complexity 6651 1956 -4695
============================================
Files 697 208 -489
Lines 68015 14426 -53589
Branches 7285 1582 -5703
============================================
- Hits 21353 5310 -16043
+ Misses 43667 8542 -35125
+ Partials 2995 574 -2421
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `36.80% <ø> (+5.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/pulsar/broker/admin/v1/BrokerStats.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJTdGF0cy5qYXZh) | | |
| [.../transaction/buffer/metadata/AbortTxnMetadata.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9idWZmZXIvbWV0YWRhdGEvQWJvcnRUeG5NZXRhZGF0YS5qYXZh) | | |
| [...ce/schema/validator/StringSchemaDataValidator.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS92YWxpZGF0b3IvU3RyaW5nU2NoZW1hRGF0YVZhbGlkYXRvci5qYXZh) | | |
| [.../org/apache/pulsar/broker/service/PulsarStats.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1bHNhclN0YXRzLmphdmE=) | | |
| [...ice/streamingdispatch/PendingReadEntryRequest.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3N0cmVhbWluZ2Rpc3BhdGNoL1BlbmRpbmdSZWFkRW50cnlSZXF1ZXN0LmphdmE=) | | |
| [...er/impl/cache/EntryCacheDefaultEvictionPolicy.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL2NhY2hlL0VudHJ5Q2FjaGVEZWZhdWx0RXZpY3Rpb25Qb2xpY3kuamF2YQ==) | | |
| [...pulsar/broker/service/PulsarCommandSenderImpl.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1B1bHNhckNvbW1hbmRTZW5kZXJJbXBsLmphdmE=) | | |
| [...er/mledger/intercept/ManagedLedgerInterceptor.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbnRlcmNlcHQvTWFuYWdlZExlZGdlckludGVyY2VwdG9yLmphdmE=) | | |
| [...n/java/org/apache/pulsar/client/api/RawReader.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9hcGkvUmF3UmVhZGVyLmphdmE=) | | |
| [...va/org/apache/pulsar/broker/web/RestException.java](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci93ZWIvUmVzdEV4Y2VwdGlvbi5qYXZh) | | |
| ... and [479 more](https://codecov.io/gh/apache/pulsar/pull/18520/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18520: [improve][build] Add lombok plugin to solve Javadoc issue.
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18520:
URL: https://github.com/apache/pulsar/pull/18520#issuecomment-1379877993
@Technoboy- I think this the root cause that the generated javadoc for 2.11.0 using pytools becomes empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18520: [improve][build] Add lombok plugin to solve Javadoc issue.
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18520:
URL: https://github.com/apache/pulsar/pull/18520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org