[GitHub] [tvm] comaniac commented on a change in pull request #8066: fix bugs in the auto-scheduler record:

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #8066:
URL: https://github.com/apache/tvm/pull/8066#discussion_r634575367



##########
File path: python/tvm/auto_scheduler/measure_record.py
##########
@@ -61,8 +64,9 @@ class RecordReader(Object):
 
     def __init__(self, filename):
         # a set to prevent print duplicated message
+        if not os.path.exists(filename):
+            raise FileExistsError("%s does not exists!" % filename)

Review comment:
       - Move the comment in L66 to the right place.
   - I'm thinking whether to error out or just a warning in this case. By looking into it use cases, it seems to me that a warning might be better, because some times users may write a script that preloads the record file whatever it exists or not. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org