You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 18:33:21 UTC

[GitHub] [felix-dev] timothyjward commented on issue #9: Convert to Interface without methods - FELIX-6238

timothyjward commented on issue #9: Convert to Interface without methods - FELIX-6238
URL: https://github.com/apache/felix-dev/pull/9#issuecomment-598859059
 
 
   This method has always been a bit odd to read - it still seems odd to check that the methods returned by the interface are defined by the interface. 
   
   As for the change, it looks correct, but would it be better to assign the output of `getMethods` to a local variable before the for loop so we don’t need to get the array twice? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services