You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Paresh Kumar Acharya (Created) (JIRA)" <de...@myfaces.apache.org> on 2011/11/09 12:58:51 UTC
[jira] [Created] (TRINIDAD-2158) NodeIterator iterates the
colection more no of times than the size of the collection.
NodeIterator iterates the colection more no of times than the size of the collection.
-------------------------------------------------------------------------------------
Key: TRINIDAD-2158
URL: https://issues.apache.org/jira/browse/TRINIDAD-2158
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.2-core
Reporter: Paresh Kumar Acharya
The class org.apache.myfaces.trinidad.model.RowKeySetTreeImpl contains two Iterator Implementations PathIterator and NodeIterator.
When the NodeIterator is used interanally to iterate the selected Tree or TreeTable nodes(rows), the iterator iterates more no of times than the total number of the slected nodes(rows). The iterator.next() returns the same node(row) more than once.
This issue occurs because of the follwoing 2 reasons.
1) The currentIterator instance is not updated by taking the next iterator from the iteratorStack when one node completeley iterator.
2) Even when a node doesn't have any child nodes, iterator instances are created and pushed to the iteratorStack.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2158) NodeIterator iterates the
colection more no of times than the size of the collection.
Posted by "Paresh Kumar Acharya (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paresh Kumar Acharya updated TRINIDAD-2158:
-------------------------------------------
Status: Patch Available (was: Open)
> NodeIterator iterates the colection more no of times than the size of the collection.
> -------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2158
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2158
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.2-core
> Reporter: Paresh Kumar Acharya
>
> The class org.apache.myfaces.trinidad.model.RowKeySetTreeImpl contains two Iterator Implementations PathIterator and NodeIterator.
> When the NodeIterator is used interanally to iterate the selected Tree or TreeTable nodes(rows), the iterator iterates more no of times than the total number of the slected nodes(rows). The iterator.next() returns the same node(row) more than once.
> This issue occurs because of the follwoing 2 reasons.
> 1) The currentIterator instance is not updated by taking the next iterator from the iteratorStack when one node completeley iterator.
> 2) Even when a node doesn't have any child nodes, iterator instances are created and pushed to the iteratorStack.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2158) NodeIterator iterates the
colection more no of times than the size of the collection.
Posted by "Andrew Robinson (Updated) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Robinson updated TRINIDAD-2158:
--------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.2-core
Status: Resolved (was: Patch Available)
> NodeIterator iterates the colection more no of times than the size of the collection.
> -------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2158
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2158
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.2-core
> Reporter: Paresh Kumar Acharya
> Fix For: 2.0.2-core
>
> Attachments: Bug13355971.patch, trunk.patch, trunk.patch
>
>
> The class org.apache.myfaces.trinidad.model.RowKeySetTreeImpl contains two Iterator Implementations PathIterator and NodeIterator.
> When the NodeIterator is used interanally to iterate the selected Tree or TreeTable nodes(rows), the iterator iterates more no of times than the total number of the slected nodes(rows). The iterator.next() returns the same node(row) more than once.
> This issue occurs because of the follwoing 2 reasons.
> 1) The currentIterator instance is not updated by taking the next iterator from the iteratorStack when one node completeley iterator.
> 2) Even when a node doesn't have any child nodes, iterator instances are created and pushed to the iteratorStack.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2158) NodeIterator iterates the
colection more no of times than the size of the collection.
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146996#comment-13146996 ]
Bernd Bohmann commented on TRINIDAD-2158:
-----------------------------------------
Please add the patch with 'ASF Granted License' selected. Thanks
> NodeIterator iterates the colection more no of times than the size of the collection.
> -------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2158
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2158
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.2-core
> Reporter: Paresh Kumar Acharya
> Attachments: trunk.patch
>
>
> The class org.apache.myfaces.trinidad.model.RowKeySetTreeImpl contains two Iterator Implementations PathIterator and NodeIterator.
> When the NodeIterator is used interanally to iterate the selected Tree or TreeTable nodes(rows), the iterator iterates more no of times than the total number of the slected nodes(rows). The iterator.next() returns the same node(row) more than once.
> This issue occurs because of the follwoing 2 reasons.
> 1) The currentIterator instance is not updated by taking the next iterator from the iteratorStack when one node completeley iterator.
> 2) Even when a node doesn't have any child nodes, iterator instances are created and pushed to the iteratorStack.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2158) NodeIterator iterates the
colection more no of times than the size of the collection.
Posted by "Paresh Kumar Acharya (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146969#comment-13146969 ]
Paresh Kumar Acharya commented on TRINIDAD-2158:
------------------------------------------------
The _nextEntry() method of NodeIterator class is updated to fix the issue.
> NodeIterator iterates the colection more no of times than the size of the collection.
> -------------------------------------------------------------------------------------
>
> Key: TRINIDAD-2158
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2158
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.2-core
> Reporter: Paresh Kumar Acharya
> Attachments: trunk.patch
>
>
> The class org.apache.myfaces.trinidad.model.RowKeySetTreeImpl contains two Iterator Implementations PathIterator and NodeIterator.
> When the NodeIterator is used interanally to iterate the selected Tree or TreeTable nodes(rows), the iterator iterates more no of times than the total number of the slected nodes(rows). The iterator.next() returns the same node(row) more than once.
> This issue occurs because of the follwoing 2 reasons.
> 1) The currentIterator instance is not updated by taking the next iterator from the iteratorStack when one node completeley iterator.
> 2) Even when a node doesn't have any child nodes, iterator instances are created and pushed to the iteratorStack.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira