You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2020/07/21 02:52:25 UTC

[GitHub] [incubator-weex] weex-bot commented on pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down

weex-bot commented on pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244#issuecomment-661592386


   
   <!--
     1 failure:  Code file ios/sdk...
     4 warning:  No Changelog chan..., Current pr not bi..., If your PR is abo..., If you update the...
     
     
     DangerID: danger-id-danger;
   -->
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Fails</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:no_entry_sign:</td>
         <td>Code file ios/sdk/WeexSDK/Sources/Component/Recycler/WXMultiColumnLayout.m has cn source code.</td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If you update the code, maybe you should update the documentation and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: <a href='https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document'>https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document</a></td>
       </tr>
     </tbody>
   </table>
   
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against abd25ba3e57a34d734664a4e7cc1eb18043c84a5
   </p>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org