[GitHub] [flink] loserwang1024 commented on a diff in pull request #23234: [FLINK-32668][e2e] fix up watchdog timeout error msg in common.sh

["loserwang1024 (via GitHub)" <gi...@apache.org>]

loserwang1024 commented on code in PR #23234:
URL: https://github.com/apache/flink/pull/23234#discussion_r1299502919


##########
flink-end-to-end-tests/test-scripts/common.sh:
##########
@@ -934,9 +934,13 @@ function extract_job_id_from_job_submission_return() {
 }
 
 kill_test_watchdog() {
-    local watchdog_pid=$(cat $TEST_DATA_DIR/job_watchdog.pid)
-    echo "Stopping job timeout watchdog (with pid=$watchdog_pid)"
-    kill $watchdog_pid
+  local watchdog_pid=$(cat $TEST_DATA_DIR/job_watchdog.pid)
+      if kill -0 $watchdog_pid > /dev/null 2>&1; then
+           echo "Stopping job timeout watchdog (with pid=$watchdog_pid)"
+           kill $watchdog_pid
+      else
+            echo "Job timeout watchdog (with pid=$watchdog_pid) has already been stopped "

Review Comment:
   I agree with you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org