You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/02/15 15:14:05 UTC

[tomcat] branch main updated (b6068def03 -> e1c869e6e0)

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


    from b6068def03 Code cleanup (format) - no functional change
     new b9b223d707 Update current error counts
     new e1c869e6e0 Undo unintentional change

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 res/checkstyle/checkstyle.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[tomcat] 01/02: Update current error counts

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit b9b223d707fd250ae69941e6372aeb44f0ba1f49
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Feb 15 15:13:34 2023 +0000

    Update current error counts
---
 res/checkstyle/checkstyle.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/res/checkstyle/checkstyle.xml b/res/checkstyle/checkstyle.xml
index cdffd62766..6c4b1e9b78 100644
--- a/res/checkstyle/checkstyle.xml
+++ b/res/checkstyle/checkstyle.xml
@@ -87,10 +87,10 @@
     <module name="JavadocMissingLeadingAsterisk"/>
     <module name="JavadocMissingWhitespaceAfterAsterisk"/>
     <module name="JavadocStyle">
-        <!-- Disabled. Large number of errors with minimal benefit to be gained by fixing at this time. ~1600 errors -->
-        <property name="checkFirstSentence" value="false"/>
         <!-- Disabled. Large number of errors with minimal benefit to be gained by fixing at this time. ~1500 errors -->
-        <property name="checkEmptyJavadoc" value="false"/>
+        <property name="checkFirstSentence" value="false"/>
+        <!-- Disabled. Large number of errors with minimal benefit to be gained by fixing at this time. ~1400 errors -->
+        <property name="checkEmptyJavadoc" value="true"/>
         <!-- Does not handle HTML tags in {@code ...} correctly -->
         <property name="checkHtml" value="false"/>
     </module>
@@ -101,13 +101,13 @@
     <module name="MissingJavadocType"/>
     -->
     <module name="NonEmptyAtclauseDescription"/>
-    <!-- ~1600 errors
+    <!-- ~1500 errors
     <module name="RequireEmptyLineBeforeBlockTagGroup"/>
     -->
     <module name="SingleLineJavadoc"/>
 
     <!-- Miscellaneous -->
-    <!-- ~5500 errors
+    <!-- ~4100 errors
     <module name="Indentation">
         <property name="lineWrappingIndentation" value="8"/>
     </module>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[tomcat] 02/02: Undo unintentional change

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit e1c869e6e033337358aa357f3af9b5ad989e56d1
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Feb 15 15:13:59 2023 +0000

    Undo unintentional change
---
 res/checkstyle/checkstyle.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/res/checkstyle/checkstyle.xml b/res/checkstyle/checkstyle.xml
index 6c4b1e9b78..c8def1716a 100644
--- a/res/checkstyle/checkstyle.xml
+++ b/res/checkstyle/checkstyle.xml
@@ -90,7 +90,7 @@
         <!-- Disabled. Large number of errors with minimal benefit to be gained by fixing at this time. ~1500 errors -->
         <property name="checkFirstSentence" value="false"/>
         <!-- Disabled. Large number of errors with minimal benefit to be gained by fixing at this time. ~1400 errors -->
-        <property name="checkEmptyJavadoc" value="true"/>
+        <property name="checkEmptyJavadoc" value="false"/>
         <!-- Does not handle HTML tags in {@code ...} correctly -->
         <property name="checkHtml" value="false"/>
     </module>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org