[jira] [Commented] (GIRAPH-537) Fix log messages produced by aggregators

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608240#comment-13608240 ] 

Hudson commented on GIRAPH-537:
-------------------------------

Integrated in Giraph-trunk-Commit #814 (See [https://builds.apache.org/job/Giraph-trunk-Commit/814/])
    GIRAPH-537: Fix log messages produced by aggregators (majakabiljo) (Revision 40bc599b8a7e7caaeb0a284fd2d2103926b79288)

     Result = FAILURE
majakabiljo : http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=40bc599b8a7e7caaeb0a284fd2d2103926b79288
Files : 
* giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToWorkerRequest.java
* giraph-core/src/main/java/org/apache/giraph/comm/requests/ByteArrayWithSenderTaskIdRequest.java
* giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerAggregatorsRequest.java
* giraph-core/src/main/java/org/apache/giraph/utils/TaskIdsPermitsBarrier.java
* giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToOwnerRequest.java
* CHANGELOG
* giraph-core/src/main/java/org/apache/giraph/utils/ExpectedBarrier.java
* giraph-core/src/main/java/org/apache/giraph/comm/aggregators/AllAggregatorServerData.java
* giraph-core/src/main/java/org/apache/giraph/worker/WorkerAggregatorHandler.java
* giraph-core/src/main/java/org/apache/giraph/comm/aggregators/OwnerAggregatorServerData.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyMasterClient.java

                
>  Fix log messages produced by aggregators
> -----------------------------------------
>
>                 Key: GIRAPH-537
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-537
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-537.patch, GIRAPH-537.patch
>
>
> When workers are synchronizing aggregators using the ExpectedBarrier class, the following message is printed:
> "waitForRequiredPermits: Waiting for times required to be X (currently Y)"
> I find this doesn't convey much about what exactly we're waiting for.
> We should make the log more meaningful and explicitly mention aggregators, at the cost of simplifying things a bit.
> Additionally, we could skip it altogether when no aggregators are being used.
> The ExpectedBarrier class itself also lacks clear documentation: what is this class for? The Javadoc explains how it works without first stating what it is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira