You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/27 03:29:57 UTC
[I] Correct the repo-health family skill count in triage-mode.md [magpie]
justinmclean opened a new issue, #931:
URL: https://github.com/apache/magpie/issues/931
## Summary
Update the repo-health family count in `tools/spec-loop/specs/triage-mode.md`
from five skills to six, so it agrees with `repo-health-family.md`.
## Background
Two specs disagree about the same countable fact. `triage-mode.md` says the
repo-health family is "a five-skill family", while `repo-health-family.md` says
"six skills deep". The sixth skill, `dependency-license-audit`, shipped and only
one of the two specs was updated. At most one can be right.
Spec `Known gaps` sections are not just documentation: the spec-loop plan beat
reads them to choose the next work item, so a gap that describes already-shipped
code sends the loop at finished work.
## Where to look
- `tools/spec-loop/specs/triage-mode.md` line 114 - the bullet claiming a
"five-skill family". It also names the five skills, so the sixth needs adding
to that list.
- `tools/spec-loop/specs/repo-health-family.md` line 133 - the six-skill
statement to align with. This file is already correct; do not change it.
- `skills/` - each skill's `SKILL.md` carries a `family:` field in its
frontmatter. Counting the ones set to repo-health settles the number.
## Acceptance criteria
- [ ] `triage-mode.md` line 114 states six skills and names
`dependency-license-audit` alongside the existing five.
- [ ] The stated count equals the number of skills whose `SKILL.md` frontmatter
carries `family: repo-health`.
- [ ] `repo-health-family.md` is left unchanged.
- [ ] `uv run --project tools/spec-validator spec-validate tools/spec-loop/specs/`
passes.
## Estimated effort
~30 minutes for someone new to the codebase, most of it reading the two specs.
## Getting started
New to Magpie? Start with
[Your first contribution](https://github.com/apache/magpie/blob/main/CONTRIBUTING.md#your-first-contribution).
---
_Note: this issue was drafted by an AI-assisted mentoring tool and may contain
mistakes. A Magpie maintainer, a real person, will be the next to engage on it.
If something here looks wrong or unclear, please say so on the issue and a
maintainer will follow up.
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5213026958
Thanks, @amh1k, @zheflow, you can work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "amh1k (via GitHub)" <gi...@apache.org>.
amh1k commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5212300568
> Apologies — I completely missed that this was already assigned to @amh1k before commenting. All yours, of course! Your frontmatter findings (7 vs 6 vs 5) go deeper than the original report — interesting that the answer turned on read-only vs Drafting-mode membership. Good luck with it, I'll pick up something else.
You can pick up this issue
I wasnt able to work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5087005201
Thanks for offering to help - it's all yours to work on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5112499365
`audit-finding-fix` carries `family: repo-health in its frontmatter but is a Drafting-mode write skill (it produces a commit), not a read-only audit. Both spec docs describe the family as read-only audits, so the "six" in repo-health-family.md is the count of read-only Triage audits, while a literal `family: repo-health` grep is the count of all members.
So before making the edit there's a decision to make:
So either Six is right, the key is wrong. The family spec is scoped to read-only audits; audit-finding-fix doesn't belong under that key and should carry a different family (or none).
Seven is right, and the prose is wrong. audit-finding-fix is genuinely a repo-health member and the family simply isn't read-only anymore. Then both docs need updating.
Option 1, I think, looks more likely to me given the family spec's stated acceptance criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "amh1k (via GitHub)" <gi...@apache.org>.
amh1k commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5088438937
## Findings before implementing this fix
I verified the repo-health family count directly against `SKILL.md`
frontmatter rather than trusting the "six" premise in this issue, and the
numbers don't line up with what's expected.
**Command used:**
```bash
for f in skills/*/SKILL.md; do
fam=$(awk '/^family:/{print; exit}' "$f")
echo "$f -> $fam"
done | grep repo-health
```
**Result — 7 skills currently carry `family: repo-health`:**
- `audit-finding-fix`
- `ci-runner-audit`
- `dependency-audit`
- `dependency-license-audit`
- `flaky-test-triage`
- `license-compliance-audit`
- `workflow-security-audit`
This means:
1. **`repo-health-family.md`'s "six skills deep" is also stale**, not just
`triage-mode.md`'s "five-skill family." The issue describes
`repo-health-family.md` as already correct and asks only for
`triage-mode.md` to be brought up to six — but six doesn't match the
frontmatter either.
2. **`audit-finding-fix` isn't named in either spec's skill list at all.**
It's not a case of one spec having a stale count that the other got
right since both documents are missing a family member.
The issue's acceptance criteria say the stated count should equal "the
number of skills whose `SKILL.md` frontmatter carries `family:
repo-health`," but also say `repo-health-family.md` should be left
unchanged. Those two instructions are now in tension, since leaving
`repo-health-family.md` unchanged means it stays wrong at six.
**Question for maintainer:** should this issue be widened to fix the
count in both specs and add `audit-finding-fix` to both skill lists? Or is
`audit-finding-fix` intentionally excluded from the public-facing
repo-health count for some other reason (e.g. it's an internal/helper
skill rather than a first-class family member, and shouldn't be counted
the same way)?
Happy to make either change once this is clarified. I didn't want to land
a fix that satisfies one acceptance criterion while quietly encoding a
different wrong number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "amh1k (via GitHub)" <gi...@apache.org>.
amh1k commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5086997940
I had like to take up this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "zheflow (via GitHub)" <gi...@apache.org>.
zheflow commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5212016870
Apologies — I completely missed that this was already assigned to @amh1k before commenting. All yours, of course! Your frontmatter findings (7 vs 6 vs 5) go deeper than the original report — interesting that the answer turned on read-only vs Drafting-mode membership. Good luck with it, I'll pick up something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "zheflow (via GitHub)" <gi...@apache.org>.
zheflow commented on issue #931:
URL: https://github.com/apache/magpie/issues/931#issuecomment-5211977081
Hi! I'd like to pick this one up as my first contribution here 🙂
While reading through the spec-loop docs I checked both files on current main — the mismatch is still there: `triage-mode.md` line 114 calls repo-health a "five-skill family" and its list indeed misses `dependency-license-audit`, while `repo-health-family.md` counts six.
Plan: bump the count to six and add the missing skill to the list in `triage-mode.md`, so the two specs agree again. Will send a small PR once assigned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Correct the repo-health family skill count in triage-mode.md [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #931: Correct the repo-health family skill count in triage-mode.md
URL: https://github.com/apache/magpie/issues/931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org