You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by rweeks <gi...@git.apache.org> on 2015/08/12 23:12:41 UTC
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
GitHub user rweeks opened a pull request:
https://github.com/apache/accumulo/pull/41
Implementation of SeekingFilter, CfCqSliceFilter and CfCqSliceSeekingFilter
Implementation for ACCUMULO-3691 including a filter which behaves similarly to the existing ColumnSliceFilter but can seek to the next potential match instead of explicitly rejecting every KV pair that falls outside the slice. Probably faster for small slices on large rows.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phemisystems/accumulo ACCUMULO-3691
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit a0c8d588109e2d8d0b3bdf862ec1d3e1e48c50e7
Author: Russ Weeks <rw...@phemi.com>
Date: 2015-07-23T03:53:01Z
Initial commit of CfCqSlice code. Renamed files but Java class names are messed up.
commit 9cc2c28251d445c86d7006bf1237ea2fd096b4e1
Author: Russ Weeks <rw...@newbrightidea.com>
Date: 2015-07-23T04:23:12Z
Removing cyclic dependency on MiniAccumuloCluster by moving tests to test module
commit 1100ba49ee09c97aadbe80429f54a13519a98552
Author: Russ Weeks <rw...@newbrightidea.com>
Date: 2015-07-23T05:48:12Z
Reformatted and added comment to SeekingFilter
commit e5ea222fa07ab8bb7211a12c87aa127146874f81
Author: Russ Weeks <rw...@phemi.com>
Date: 2015-07-24T00:20:08Z
Slice tests passing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Posted by rweeks <gi...@git.apache.org>.
Github user rweeks commented on the pull request:
https://github.com/apache/accumulo/pull/41#issuecomment-130452617
Ahh shoot I could do better with some javadoc [here|https://github.com/apache/accumulo/pull/41/files#diff-f2f053c299562ad7fa7ca3d67a3a782bR57] and elsewhere. I'm not sure how to revoke a pull request but I'll add some documentation and resubmit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Posted by rweeks <gi...@git.apache.org>.
Github user rweeks closed the pull request at:
https://github.com/apache/accumulo/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/41#issuecomment-130765252
This is neat. Some class level javadoc on SeekingFilter would also be nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/41#issuecomment-130453473
This pull request should be for ACCUMULO-3961.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: Implementation of SeekingFilter, CfCqSliceF...
Posted by rweeks <gi...@git.apache.org>.
Github user rweeks commented on the pull request:
https://github.com/apache/accumulo/pull/41#issuecomment-130453675
Wow, I am really off the ball today. Sorry. I'll close this request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---