You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by tushargosavi <gi...@git.apache.org> on 2016/02/27 14:35:35 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...
GitHub user tushargosavi opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/203
APEXMALHAR-2004: Add file's modification time in referenceTimes map instead of parent's
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tushargosavi/incubator-apex-malhar APEXMALHAR-2004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 82edf12b8dd967b71c5f61bda84a64f026501c53
Author: Tushar R. Gosavi <tu...@apache.org>
Date: 2016-02-27T13:04:38Z
APEXMALHAR-2004: Add file's modification time in referenceTimes map
instead of parent's
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/203#discussion_r55806762
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -439,12 +439,12 @@ protected ScannedFileInfo createScannedFileInfo(Path parentPath, FileStatus pare
ScannedFileInfo info;
if (rootPath == null) {
info = parentStatus.isDirectory() ?
- new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), parentStatus.getModificationTime()) :
- new ScannedFileInfo(null, childPath.toUri().getPath(), parentStatus.getModificationTime());
+ new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), childStatus.getModificationTime()) :
+ new ScannedFileInfo(null, childPath.toUri().getPath(), childStatus.getModificationTime());
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2004: Add file's mo...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/203#discussion_r54475635
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -439,12 +439,12 @@ protected ScannedFileInfo createScannedFileInfo(Path parentPath, FileStatus pare
ScannedFileInfo info;
if (rootPath == null) {
info = parentStatus.isDirectory() ?
- new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), parentStatus.getModificationTime()) :
- new ScannedFileInfo(null, childPath.toUri().getPath(), parentStatus.getModificationTime());
+ new ScannedFileInfo(parentPath.toUri().getPath(), childPath.getName(), childStatus.getModificationTime()) :
+ new ScannedFileInfo(null, childPath.toUri().getPath(), childStatus.getModificationTime());
--- End diff --
please remove ```@SuppressWarnings("UnusedParameters")``` with ```childStatus``` in the method definition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---