You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Chinna Rao Lalam (Jira)" <ji...@apache.org> on 2020/04/15 15:36:00 UTC

[jira] [Commented] (HIVE-23028) Should not use group parameter when run tests in standalone-metastore-common

    [ https://issues.apache.org/jira/browse/HIVE-23028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084182#comment-17084182 ] 

Chinna Rao Lalam commented on HIVE-23028:
-----------------------------------------

+1

> Should not use group parameter when run tests in standalone-metastore-common
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-23028
>                 URL: https://issues.apache.org/jira/browse/HIVE-23028
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zhenyu Zheng
>            Assignee: Zhenyu Zheng
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-23028.1.patch
>
>
> Should not use group parameter when run tests in standalone-metastore-common
> we inherited the `group` parameter from ‘standalone-metastore’s pom.xml and there the parameter
> is set to : org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest
> ([https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml#L61]) which only exists in metastore-server package:
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/annotation/MetastoreUnitTest.java]
> and for tests for metastore-common package does not have the @Catagory header:
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/utils/RetryTest.java]
>  
> and it was actually introduced by:
> [https://github.com/apache/hive/commit/7411d42579ffa0bad96e8da731a1a35afc9ff614#diff-171fcb0dda3bcba577fa13720d5b6571]
> we should remove the group paramenter in [https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml|https://github.com/apache/hive/blob/master/standalone-metastore/pom.xml#L61]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)