You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/24 02:33:26 UTC
[GitHub] [commons-compress] garydgregory commented on a diff in pull request #298: Remove duplicate conditions. Use switch instead.
garydgregory commented on code in PR #298:
URL: https://github.com/apache/commons-compress/pull/298#discussion_r905669230
##########
src/main/java/org/apache/commons/compress/harmony/pack200/MetadataBandGroup.java:
##########
@@ -242,29 +242,48 @@ public void addParameterAnnotation(final int numParams, final int[] annoN, final
for (Object element : t) {
final String tag = (String) element;
T.add(tag);
- if (tag.equals("B") || tag.equals("C") || tag.equals("I") || tag.equals("S") || tag.equals("Z")) {
- final Integer value = (Integer) valuesIterator.next();
- caseI_KI.add(cpBands.getConstant(value));
- } else if (tag.equals("D")) {
- final Double value = (Double) valuesIterator.next();
- caseD_KD.add(cpBands.getConstant(value));
- } else if (tag.equals("F")) {
- final Float value = (Float) valuesIterator.next();
- caseF_KF.add(cpBands.getConstant(value));
- } else if (tag.equals("J")) {
- final Long value = (Long) valuesIterator.next();
- caseJ_KJ.add(cpBands.getConstant(value));
- } else if (tag.equals("c")) {
- final String value = (String) valuesIterator.next();
- casec_RS.add(cpBands.getCPSignature(value));
- } else if (tag.equals("e")) {
- final String value = (String) valuesIterator.next();
- final String value2 = (String) valuesIterator.next();
- caseet_RS.add(cpBands.getCPSignature(value));
- caseec_RU.add(cpBands.getCPUtf8(value2));
- } else if (tag.equals("s")) {
- final String value = (String) valuesIterator.next();
- cases_RU.add(cpBands.getCPUtf8(value));
+ switch (tag) {
+ case "B":
+ case "C":
+ case "I":
+ case "S":
+ case "Z": {
+ final Integer value = (Integer) valuesIterator.next();
Review Comment:
in-line local vars?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org