You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/08/16 11:18:18 UTC

[GitHub] [dolphinscheduler] TianlinLIAO opened a new issue #5993: [Question] why not worker update task instance status after task completes

TianlinLIAO opened a new issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993


   I know that the current design is: 
   
   - worker will execute the task (TaskExecuteThread.java#run)
   - after task is finished, call back service will send TaskExecuteResponseCommand to master
   - then master will update the cache, and save the task status into db. (TaskResponseService.java#persist)
   
   I wonder why not worker update task instance status after task completes. After worker updates the task status, it still can send rpc request to master to update the cache.
   And what is the benefit the current design?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-1025012723


   This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] geosmart commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
geosmart commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-999955884


   the master responsible to interact with database,  package the db data with command and send it by netty.
   so the worker just need to run the task and return the result. 
   
   this is more simple than both master and worker need to interact with db.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-899431229


   Hi:
   * Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] CalvinKirs commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-902395842


   The worker is responsible for the execution of tasks, does not interact with the database, and is managed by the master to maintain the execution of subsequent tasks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-1019381716


   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] closed issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5993: [Question] why not worker update task instance status after task completes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5993:
URL: https://github.com/apache/dolphinscheduler/issues/5993#issuecomment-999953333


   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org