You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/26 15:01:36 UTC
[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #44: added mongoose plugin
tom-pytel opened a new pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44
Too bad you already released 0.2.0, I wanted to get this last plugin in before that. It is not done yet, still need to test some more and write automated test. Also need to add the Component ID in the main skywalking repository and I think a logo goes somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] zhaozhiming commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
zhaozhiming commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-875415936
Hi, I found a problem, when I add skywalking agent in my server, the mongoose api is broken. The `find` api is ok but it return a `Promise` but not a mongoose model. when I remove the agent everything is fine.
I see that this case is not included in the test case, maybe it could be added to it.
```js
const result = await this.model.find({}).exec();
// ERROR 57176 nodejs.TypeError: model.find(...).exec is not a function
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-808749897
If you want just use the previous good version of package-lock and add mongoose as a dependency yourself or if you want I try again and hopefully npm behaves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] wu-sheng commented on pull request #44: added mongoose plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-808306360
> Too bad you already released 0.2.0
We could have 0.3.0 when need :) Releasing one agent is not relying on many things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-808749768
> The `package-lock.json` doesn't seem to be updated correctly, (seems it contains the dependencies of skywalking-nodejs itself and thus its depdnecneies duplicately), I simply checked out this PR and run `npm install`, the `package-lock.json` file is much more reduced, ~10000 lines!!), can you check ?
My npm probably mangled it when I added mongoose as a dev dependancy for the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel edited a comment on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-875508764
> ```js
> const result = await this.model.find({}).exec();
> // ERROR 57176 nodejs.TypeError: model.find(...).exec is not a function
> ```
Just an update @zhaozhiming, not sure yet when I will be able to get to this but a temporary fix would be to simply await the `.find()` and leave out the `.exec()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-875422378
> Hi, I found a problem, when I add skywalking agent in my server, the mongoose api is broken. The `find` api is ok but it return a `Promise` but not a mongoose model. when I remove the agent everything is fine.
> I see that this case is not included in the test case, maybe it could be added to it.
>
> ```js
> const result = await this.model.find({}).exec();
> // ERROR 57176 nodejs.TypeError: model.find(...).exec is not a function
> ```
@tom-pytel mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-875508764
> Hi, I found a problem, when I add skywalking agent in my server, the mongoose api is broken. The `find` api is ok but it return a `Promise` but not a mongoose model. when I remove the agent everything is fine.
> I see that this case is not included in the test case, maybe it could be added to it.
>
> ```js
> const result = await this.model.find({}).exec();
> // ERROR 57176 nodejs.TypeError: model.find(...).exec is not a function
> ```
Ok well right off the bat I think I see the problem, the returned promise is a wrapped promise and `exec()` is not instrumented on that. Fixable, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-808751483
Confirmed, my npm v7.6.3 keeps doing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44#issuecomment-808728216
BTW, this is good for merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #44: Node Mongoose Plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #44:
URL: https://github.com/apache/skywalking-nodejs/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org