You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@sentry.apache.org by "Alexander Kolbasov (JIRA)" <ji...@apache.org> on 2016/11/03 03:56:58 UTC

[jira] [Updated] (SENTRY-1505) CommitContext isn't used by anything and should be removed

     [ https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Kolbasov updated SENTRY-1505:
---------------------------------------
    Attachment: SENTRY-1505.2.patch

Re-merged with SENTRY-1422 changes

> CommitContext isn't used by anything and should be removed
> ----------------------------------------------------------
>
>                 Key: SENTRY-1505
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1505
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 1.7.0, sentry-ha-redesign
>            Reporter: Alexander Kolbasov
>            Assignee: Alexander Kolbasov
>            Priority: Minor
>         Attachments: SENTRY-1505.0.patch, SENTRY-1505.1.patch, SENTRY-1505.2.patch
>
>
> Sentry code defines class CommitContext which keeps track of sequence ID for transaction. It is passed around many places in the server code but isn't actually used by anything, so it is a dead code that should be trimmed. It just complicates things without any benefit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)