You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/17 06:29:16 UTC
[GitHub] zeppelin pull request #2255: [HOTFIX] Invalid method signature in GroovyInte...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2255
[HOTFIX] Invalid method signature in GroovyInterpreter
### What is this PR for?
- https://github.com/apache/zeppelin/pull/2203 was merged
- but https://github.com/apache/zeppelin/pull/2203 is not rebased recently.
- as a result, `GroovyInterperter` has invalid method signature.
```
[ERROR] COMPILATION ERROR :
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3] method does not override or implement a method from a supertype
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-groovy: Compilation failure
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3] method does not override or implement a method from a supertype
```
- https://travis-ci.org/1ambda/zeppelin/builds/222709985
### What type of PR is it?
[Hot Fix]
### Todos
NONE
### What is the Jira issue?
Hotfix
### How should this be tested?
CI should be green.
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin HOTFIX/GroovyInterpreter-has-invalid-overrided-method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2255
----
commit 29e840f8f41519f36f41c5f8288e27ca6df80afe
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-17T06:24:20Z
fix: Method signature in GroovyInterpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2255: [HOTFIX] Invalid method signature in GroovyInterpreter
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2255
Merge into master as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2255: [HOTFIX] Invalid method signature in GroovyInte...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2255: [HOTFIX] Invalid method signature in GroovyInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2255
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2255: [HOTFIX] Invalid method signature in GroovyInte...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2255
[HOTFIX] Invalid method signature in GroovyInterpreter
### What is this PR for?
- https://github.com/apache/zeppelin/pull/2203 was merged
- but https://github.com/apache/zeppelin/pull/2203 was not rebased recently
- as a result, `GroovyInterperter` has invalid method signature.
```
[ERROR] COMPILATION ERROR :
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3] method does not override or implement a method from a supertype
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-groovy: Compilation failure
[ERROR] /home/travis/build/1ambda/zeppelin/groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java:[123,3] method does not override or implement a method from a supertype
```
You can see CI failures in
- https://travis-ci.org/1ambda/zeppelin/jobs/222709988
- https://travis-ci.org/1ambda/zeppelin/jobs/222709989
### What type of PR is it?
[Hot Fix]
### Todos
NONE
### What is the Jira issue?
Hotfix
### How should this be tested?
- CI should be green.
- Build this PR locally, `mvn clean package -DskipTests;`
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin HOTFIX/GroovyInterpreter-has-invalid-overrided-method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2255
----
commit 29e840f8f41519f36f41c5f8288e27ca6df80afe
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-17T06:24:20Z
fix: Method signature in GroovyInterpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2255: [HOTFIX] Invalid method signature in GroovyInte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---