You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@edgent.apache.org by Cazen <gi...@git.apache.org> on 2016/05/03 16:55:48 UTC

[GitHub] incubator-quarks-website pull request: [QUARKS-164] Navigation men...

GitHub user Cazen opened a pull request:

    https://github.com/apache/incubator-quarks-website/pull/57

    [QUARKS-164] Navigation menu works the wrong way

    I think that "Closes the Responsive Menu on Menu Item Click" function is unnecessary.
    Mobile device that receives a "touch input" doesn't have "mouse over". So we should click on 1depth menu if wanna to see a 2depth menu. But in case of that, nav-bar will be collapsed. 
    landing-page.js seems that used index.html only.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks-website QUARKS-164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks-website/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 88b91ab600ea7bc25485ec4cf5ed3923b737d314
Author: cazen.lee <ca...@samsung.com>
Date:   2016-05-03T09:29:13Z

    remove "Closes the Responsive Menu on Menu Item Click" function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-164] Navigation men...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quarks-website/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---