You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jean-Louis MONTEIRO <je...@gmail.com> on 2019/09/02 21:05:41 UTC
DISCUSS Release for Geronimo Annotations 1.3
Hi guys,
I ran the TCK for Annotations 1.3.
It's simple as it's only signature validation.
I found 2 issues that I fixed and now I'd like to do the actual release.
Is that ok?
--
Jean-Louis
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Mark Struberg <st...@yahoo.de>.
+1
LieGrue,
strub
> Am 03.09.2019 um 09:45 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> +1
>
> Romain Manni-Bucau
> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le mar. 3 sept. 2019 à 09:44, Jean-Louis MONTEIRO <je...@gmail.com> a écrit :
> Everything is green now
> <image.png>
>
> am I ok to run the release?
>
>
> Le mar. 3 sept. 2019 à 09:35, Romain Manni-Bucau <rm...@gmail.com> a écrit :
> Oki so let's get it out :)
>
> Romain Manni-Bucau
> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le mar. 3 sept. 2019 à 09:18, Jean-Louis MONTEIRO <je...@gmail.com> a écrit :
> Hi Romain,
>
> This is the changes I made.
> Nothing big or potentially breaking applications.
>
> It's the signature part yes.
> Basically @Repeatable was missing on @Resource and @DataSourceDefinition
>
> See https://svn.apache.org/viewvc?view=revision&revision=1866293
>
>
>
>
>
> Le lun. 2 sept. 2019 à 23:29, Romain Manni-Bucau <rm...@gmail.com> a écrit :
> Hi JL,
>
> I didnt find the commits in mail archives, is it a list setup issue? Does it break binary compatibility/class or method signatures?
>
> Otherwise it sounds good. Can test on a few projects relying on annotation bundle tomorrow.
>
> Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com> a écrit :
> Hi guys,
>
> I ran the TCK for Annotations 1.3.
> It's simple as it's only signature validation.
>
> I found 2 issues that I fixed and now I'd like to do the actual release.
> Is that ok?
>
> --
> Jean-Louis
>
>
> --
> Jean-Louis
>
>
> --
> Jean-Louis
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 3 sept. 2019 à 09:44, Jean-Louis MONTEIRO <je...@gmail.com> a
écrit :
> Everything is green now
> [image: image.png]
>
> am I ok to run the release?
>
>
> Le mar. 3 sept. 2019 à 09:35, Romain Manni-Bucau <rm...@gmail.com>
> a écrit :
>
>> Oki so let's get it out :)
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>>
>> Le mar. 3 sept. 2019 à 09:18, Jean-Louis MONTEIRO <je...@gmail.com> a
>> écrit :
>>
>>> Hi Romain,
>>>
>>> This is the changes I made.
>>> Nothing big or potentially breaking applications.
>>>
>>> It's the signature part yes.
>>> Basically @Repeatable was missing on @Resource and @DataSourceDefinition
>>>
>>> See https://svn.apache.org/viewvc?view=revision&revision=1866293
>>>
>>>
>>>
>>>
>>>
>>> Le lun. 2 sept. 2019 à 23:29, Romain Manni-Bucau <rm...@gmail.com>
>>> a écrit :
>>>
>>>> Hi JL,
>>>>
>>>> I didnt find the commits in mail archives, is it a list setup issue?
>>>> Does it break binary compatibility/class or method signatures?
>>>>
>>>> Otherwise it sounds good. Can test on a few projects relying on
>>>> annotation bundle tomorrow.
>>>>
>>>> Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com>
>>>> a écrit :
>>>>
>>>>> Hi guys,
>>>>>
>>>>> I ran the TCK for Annotations 1.3.
>>>>> It's simple as it's only signature validation.
>>>>>
>>>>> I found 2 issues that I fixed and now I'd like to do the actual
>>>>> release.
>>>>> Is that ok?
>>>>>
>>>>> --
>>>>> Jean-Louis
>>>>>
>>>>
>>>
>>> --
>>> Jean-Louis
>>>
>>
>
> --
> Jean-Louis
>
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Everything is green now
[image: image.png]
am I ok to run the release?
Le mar. 3 sept. 2019 à 09:35, Romain Manni-Bucau <rm...@gmail.com> a
écrit :
> Oki so let's get it out :)
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le mar. 3 sept. 2019 à 09:18, Jean-Louis MONTEIRO <je...@gmail.com> a
> écrit :
>
>> Hi Romain,
>>
>> This is the changes I made.
>> Nothing big or potentially breaking applications.
>>
>> It's the signature part yes.
>> Basically @Repeatable was missing on @Resource and @DataSourceDefinition
>>
>> See https://svn.apache.org/viewvc?view=revision&revision=1866293
>>
>>
>>
>>
>>
>> Le lun. 2 sept. 2019 à 23:29, Romain Manni-Bucau <rm...@gmail.com>
>> a écrit :
>>
>>> Hi JL,
>>>
>>> I didnt find the commits in mail archives, is it a list setup issue?
>>> Does it break binary compatibility/class or method signatures?
>>>
>>> Otherwise it sounds good. Can test on a few projects relying on
>>> annotation bundle tomorrow.
>>>
>>> Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com>
>>> a écrit :
>>>
>>>> Hi guys,
>>>>
>>>> I ran the TCK for Annotations 1.3.
>>>> It's simple as it's only signature validation.
>>>>
>>>> I found 2 issues that I fixed and now I'd like to do the actual release.
>>>> Is that ok?
>>>>
>>>> --
>>>> Jean-Louis
>>>>
>>>
>>
>> --
>> Jean-Louis
>>
>
--
Jean-Louis
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Oki so let's get it out :)
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 3 sept. 2019 à 09:18, Jean-Louis MONTEIRO <je...@gmail.com> a
écrit :
> Hi Romain,
>
> This is the changes I made.
> Nothing big or potentially breaking applications.
>
> It's the signature part yes.
> Basically @Repeatable was missing on @Resource and @DataSourceDefinition
>
> See https://svn.apache.org/viewvc?view=revision&revision=1866293
>
>
>
>
>
> Le lun. 2 sept. 2019 à 23:29, Romain Manni-Bucau <rm...@gmail.com>
> a écrit :
>
>> Hi JL,
>>
>> I didnt find the commits in mail archives, is it a list setup issue? Does
>> it break binary compatibility/class or method signatures?
>>
>> Otherwise it sounds good. Can test on a few projects relying on
>> annotation bundle tomorrow.
>>
>> Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com> a
>> écrit :
>>
>>> Hi guys,
>>>
>>> I ran the TCK for Annotations 1.3.
>>> It's simple as it's only signature validation.
>>>
>>> I found 2 issues that I fixed and now I'd like to do the actual release.
>>> Is that ok?
>>>
>>> --
>>> Jean-Louis
>>>
>>
>
> --
> Jean-Louis
>
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Hi Romain,
This is the changes I made.
Nothing big or potentially breaking applications.
It's the signature part yes.
Basically @Repeatable was missing on @Resource and @DataSourceDefinition
See https://svn.apache.org/viewvc?view=revision&revision=1866293
Le lun. 2 sept. 2019 à 23:29, Romain Manni-Bucau <rm...@gmail.com> a
écrit :
> Hi JL,
>
> I didnt find the commits in mail archives, is it a list setup issue? Does
> it break binary compatibility/class or method signatures?
>
> Otherwise it sounds good. Can test on a few projects relying on annotation
> bundle tomorrow.
>
> Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com> a
> écrit :
>
>> Hi guys,
>>
>> I ran the TCK for Annotations 1.3.
>> It's simple as it's only signature validation.
>>
>> I found 2 issues that I fixed and now I'd like to do the actual release.
>> Is that ok?
>>
>> --
>> Jean-Louis
>>
>
--
Jean-Louis
Re: DISCUSS Release for Geronimo Annotations 1.3
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi JL,
I didnt find the commits in mail archives, is it a list setup issue? Does
it break binary compatibility/class or method signatures?
Otherwise it sounds good. Can test on a few projects relying on annotation
bundle tomorrow.
Le lun. 2 sept. 2019 à 23:06, Jean-Louis MONTEIRO <je...@gmail.com> a
écrit :
> Hi guys,
>
> I ran the TCK for Annotations 1.3.
> It's simple as it's only signature validation.
>
> I found 2 issues that I fixed and now I'd like to do the actual release.
> Is that ok?
>
> --
> Jean-Louis
>