[jira] [Resolved] (JAMES-2382) Inconsistent method name

["Tellier Benoit (JIRA)" <se...@james.apache.org>]

     [ https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tellier Benoit resolved JAMES-2382.
-----------------------------------
    Resolution: Fixed

https://github.com/apache/james-project/pull/110 solved the issue.

> Inconsistent method name
> ------------------------
>
>                 Key: JAMES-2382
>                 URL: https://issues.apache.org/jira/browse/JAMES-2382
>             Project: James Server
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named "hasAnnotatedProperty" that is a query of asking whether the propertyDescriptor has the AnnotatedProperty or not.
> Actually, the method returns an AnnotatedProperty found by the propertyDescriptor.
> Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".
> {code:java}
>     private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
>         Method setter = propertyDescriptor.getWriteMethod();
>         return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation()) : null;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org