You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/03/19 09:51:27 UTC

[jira] Created: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Bugs on listStatus for HarFileSystem
------------------------------------

                 Key: HADOOP-6645
                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 0.22.0
            Reporter: Rodrigo Schmidt
            Assignee: Rodrigo Schmidt
             Fix For: 0.22.0


Two bugs on listStatus for HarFileSystem:

1) consider the following directory tree inside a hadoop archive
/foo
/foo/bar1
/fooo
/fooo/bar2

In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.

2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated HADOOP-6645:
------------------------------------

    Attachment: HADOOP-6645.hotfix.patch

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850047#action_12850047 ] 

Hudson commented on HADOOP-6645:
--------------------------------

Integrated in Hadoop-Common-trunk #287 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/287/])
    . Re: Bugs on listStatus for HarFileSystem (rodrigo via mahadev)


> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849007#action_12849007 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Yes, ivy does replace things from its cache. I was running into this problem before I learned the maven tricks with ivy cache deletion.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848997#action_12848997 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Yes, they passed for me.

It's a bit tricky to test things from a different hadoop-common jar, though. For ant to take the right file I had to run "ant mvn-install" on my hadoop-common install. Thencleared the jar inside ~/ivy2/cache/... (this is very important), went to my hadoop-mapreduce install and ran "ant test -Dresolvers=internal -Dtestcase=TestHadoopArchives".

Did you do all that too?

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849048#action_12849048 ] 

Hadoop QA commented on HADOOP-6645:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12439606/HADOOP-6645.hotfix.patch
  against trunk revision 926421.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/429/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/429/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/429/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/429/console

This message is automatically generated.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-6645:
----------------------------------

    Status: Open  (was: Patch Available)

trying hudson again!

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-6645:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. thanks rodrigo!

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847691#action_12847691 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Mahadev, Nicholas, can one of you take a quick look at this patch? It's a simple one and I've already tested it with TestHarFileSystem.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated HADOOP-6645:
------------------------------------

    Attachment: HADOOP-6645.patch

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated HADOOP-6645:
------------------------------------

    Status: Patch Available  (was: Open)

Unfortunately the unit tests for HarFileSystem must be inside MAPREDUCE, since that is where HadoopArchives (the archive creation tool) resides.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-6645:
----------------------------------

    Status: Patch Available  (was: Open)

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849270#action_12849270 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

rodrigo, 
 I ran the tests on mapreduce with this patch and the test passes!

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849067#action_12849067 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Mahadev, Nicholas, Can one of you just double check if this new patch passes the TestHadoopArchives test? I've already tested it in my machine but with this whole ivy/maven complexity, I would feel more comfortable if someone else checked it (so that I don't break trunk once more).

Feel free to commit the patch afterward, if you think it's okay.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848659#action_12848659 ] 

Hudson commented on HADOOP-6645:
--------------------------------

Integrated in Hadoop-Common-trunk #285 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/285/])
    .  Bugs on listStatus for HarFileSystem (rodrigo via mahadev)


> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849003#action_12849003 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

I tried a short cut of copying hadoop-core.jar from the common build to build/ivy/lib..... looks like ivy does some weird thing where it replaces it with the one fetched from ivy cache. but clean up everything and use maven install seems to work.... I wonder why we have to use ivy for all this (maven all over would have been a better choice).... 

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848492#action_12848492 ] 

Hudson commented on HADOOP-6645:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #208 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/208/])
    .  Bugs on listStatus for HarFileSystem (rodrigo via mahadev)


> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848219#action_12848219 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

good catch rodrigo. Sorry just skimmed through the description and thats why the stupid question above! :) 


+1 for the patch. 

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848856#action_12848856 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-6645:
------------------------------------------------

It seems that TestHadoopArchives in mapred is failing after this.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-6645:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. thanks rodrigo!

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848279#action_12848279 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Yes I am. I just haven't had the time to upload the new patch yet.

It's a good test case to have.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849325#action_12849325 ] 

Hudson commented on HADOOP-6645:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #209 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/209/])
    . Re: Bugs on listStatus for HarFileSystem (rodrigo via mahadev)


> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847293#action_12847293 ] 

Hadoop QA commented on HADOOP-6645:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12439255/HADOOP-6645.patch
  against trunk revision 923619.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/422/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/422/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/422/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/422/console

This message is automatically generated.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848021#action_12848021 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

{code}
-      String parentString = parent.getName();
+      String parentString = parent.getName() + Path.SEPARATOR;
{code}

rodrigo,
  do the tests fail without adding the Path.SEPERATOR? Why is it necessary to append a path.separator?

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848863#action_12848863 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

I'm checking it.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848047#action_12848047 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Thanks for looking at it, Mahadev!
If we don't add the separator, the selection if will pass for /fooo/bar2 when we ask to list the contents of /foo in the example I gave in the JIRA description. Adding Path.SEPARATOR makes sure that we only select children of the right parent, and not children of a parent that is an extension of the right one.

The current unit tests don't cover this case... However, unit tests are in the MAPREDUCE project and I can't add them in HADOOP patches like this one. To avoid errors, we have to commit this patch first and then add new unit tests to MAPREDUCE. :-(

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848894#action_12848894 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

This new patch should fix the problem.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848993#action_12848993 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

rodrigo,
 the tests still fail for me. Are you sure it fixes the tests for you?

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt updated HADOOP-6645:
------------------------------------

    Status: Patch Available  (was: Reopened)

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rodrigo Schmidt reopened HADOOP-6645:
-------------------------------------


I didn't cover the case in which the parent directory is "/"

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849284#action_12849284 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

Great! Can you commit it?

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847284#action_12847284 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

The second bug is my fault. My patch for HADOOP-6591 was based on a patch for a version of hadoop 0.20 that didn't have fileStatusesIndex(). It doesn't break anything because we haven't committed the patch that generates the v2 files. However, it does prevent that patch from passing the unit tests.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848221#action_12848221 ] 

Mahadev konar commented on HADOOP-6645:
---------------------------------------

also, are you adding test case to MAPREDUCE-1585 ? It would be good to have a good test case for the above!

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848881#action_12848881 ] 

Rodrigo Schmidt commented on HADOOP-6645:
-----------------------------------------

I think I found the problem.

My bad! I tested it against my local version of mapreduce, in which I had taken TestHadoopArchives out. I'm reopening the task and will submit a new patch, after I do some extra testing.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848933#action_12848933 ] 

Hadoop QA commented on HADOOP-6645:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12439606/HADOOP-6645.hotfix.patch
  against trunk revision 926421.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 common tests.  The patch failed common unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/428/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/428/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/428/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/428/console

This message is automatically generated.

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6645) Bugs on listStatus for HarFileSystem

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-6645:
-------------------------------------------

    Component/s: fs

> Bugs on listStatus for HarFileSystem
> ------------------------------------
>
>                 Key: HADOOP-6645
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6645
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Rodrigo Schmidt
>            Assignee: Rodrigo Schmidt
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6645.hotfix.patch, HADOOP-6645.patch
>
>
> Two bugs on listStatus for HarFileSystem:
> 1) consider the following directory tree inside a hadoop archive
> /foo
> /foo/bar1
> /fooo
> /fooo/bar2
> In this case, listStatus(new Path("/foo")) will include /fooo/bar2 because fileStatusesInIndex is testing  a prefix.
> 2) HADOOP-6591 didn't take into consideration method fileStatusesInIndex(), and archives v2 return empty results for listStatus()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.